[#330] Support data files not found#331
Merged
LorenzzoQM merged 2 commits intodevelopfrom Feb 3, 2026
Merged
Conversation
6e982c8 to
0e6728d
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #330 where Basilisk's support data files have been moved to a different path in version 2.9.0, causing FileNotFoundError when using BSK-RL with Basilisk installed from wheels. The solution implements a fallback mechanism that tries to use the new Basilisk dataFetcher API and falls back to the legacy path if the new API is not available.
Changes:
- Added try/except import blocks for the new Basilisk dataFetcher API in both
orbital.pyandworld.py - Updated path construction logic to use the new API when available, otherwise use legacy paths
- Updated release notes to document the compatibility enhancement
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/bsk_rl/utils/orbital.py | Added dataFetcher API import with fallback and updated TrajectorySimulator to use new path resolution logic |
| src/bsk_rl/sim/world.py | Added dataFetcher API import with fallback and updated WorldModel.setup_gravity_bodies to use new path resolution logic |
| docs/source/release_notes.rst | Added release note documenting the compatibility update for Basilisk's new dataFetcher API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0e6728d to
3d5e009
Compare
Contributor
ReeceHumphreys
left a comment
There was a problem hiding this comment.
Just some thoughts.
Mark2000
approved these changes
Feb 3, 2026
Contributor
Mark2000
left a comment
There was a problem hiding this comment.
I like this path forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #330
Tries to import new Basilisk dataFetcher API. Falls back to legacy path if not available.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Pytest tests passed.
Checklist