Skip to content

[#330] Support data files not found#331

Merged
LorenzzoQM merged 2 commits intodevelopfrom
bug/support_file_not_found
Feb 3, 2026
Merged

[#330] Support data files not found#331
LorenzzoQM merged 2 commits intodevelopfrom
bug/support_file_not_found

Conversation

@LorenzzoQM
Copy link
Contributor

Description

Closes #330

Tries to import new Basilisk dataFetcher API. Falls back to legacy path if not available.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Pytest tests passed.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@LorenzzoQM LorenzzoQM requested review from Mark2000 and Copilot and removed request for Copilot February 2, 2026 21:04
@LorenzzoQM LorenzzoQM force-pushed the bug/support_file_not_found branch from 6e982c8 to 0e6728d Compare February 3, 2026 00:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #330 where Basilisk's support data files have been moved to a different path in version 2.9.0, causing FileNotFoundError when using BSK-RL with Basilisk installed from wheels. The solution implements a fallback mechanism that tries to use the new Basilisk dataFetcher API and falls back to the legacy path if the new API is not available.

Changes:

  • Added try/except import blocks for the new Basilisk dataFetcher API in both orbital.py and world.py
  • Updated path construction logic to use the new API when available, otherwise use legacy paths
  • Updated release notes to document the compatibility enhancement

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/bsk_rl/utils/orbital.py Added dataFetcher API import with fallback and updated TrajectorySimulator to use new path resolution logic
src/bsk_rl/sim/world.py Added dataFetcher API import with fallback and updated WorldModel.setup_gravity_bodies to use new path resolution logic
docs/source/release_notes.rst Added release note documenting the compatibility update for Basilisk's new dataFetcher API

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LorenzzoQM LorenzzoQM force-pushed the bug/support_file_not_found branch from 0e6728d to 3d5e009 Compare February 3, 2026 01:01
Copy link
Contributor

@ReeceHumphreys ReeceHumphreys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some thoughts.

Copy link
Contributor

@Mark2000 Mark2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this path forward.

@LorenzzoQM LorenzzoQM merged commit 3876954 into develop Feb 3, 2026
7 checks passed
@LorenzzoQM LorenzzoQM deleted the bug/support_file_not_found branch February 3, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileNotFoundError when installing Basilisk from wheels

3 participants