[FIX] Change how legacy ItemType is processed to handle nolink value#107
Merged
AaronSadlerUK merged 1 commit intoFeb 13, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing this with some real data the values for "ItemType" used to be
linkornolink. The migration was erroring because these were not valid for the enum it tried to parse to.Changed the deserialisation process to put the original value into a string and the new property to try and convert, performing a bit of logic to differentiate between external and content links. If there is something other than those two values it will try and parse it into the enum, and if that fails it will throw an exception (not seen any other variants occur but it's always possible).