Enhances custom item type registration#111
Closed
AaronSadlerUK wants to merge 3 commits into
Closed
Conversation
Updated docs too
Resolve conflict in UmbNavItemTests.cs - keep both custom item type tests and nullable Published tests from develop. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Standardize all frontend itemType values to PascalCase to match C# UmbNavItemType constants, fixing broken "Include Child Nodes" toggle for Document items. Add #openCustomEditModal to handle custom types with editModalToken instead of silently ignoring edit clicks. Grant write permission to claude-code-review workflow for PR comments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the registration process for custom item types in UmbNav, ensuring they are correctly preserved and editable.
This change introduces:
This enhancement resolves issues with custom item types not being properly recognized and managed within the UmbNav interface.
Fixes #105