4.1.6

.github/workflows/dotnet-build-prelease.yml

@@ -32,7 +32,7 @@ jobs:
             10.x
 
       - name: Install GitVersion
-        uses: gittools/actions/gitversion/setup@v4.2.0
+        uses: gittools/actions/gitversion/setup@v4.5.0
         with:
           versionSpec: '6.x'
 
@@ -80,7 +80,7 @@ jobs:
 
       - name: Determine Version with GitVersion (MSBuild in Proj will do this)
         id:   gitversion
-        uses: gittools/actions/gitversion/execute@v4.2.0
+        uses: gittools/actions/gitversion/execute@v4.5.0
         with:
           useConfigFile: true
           configFilePath: ./GitVersion.yml

.github/workflows/dotnet-build.stablerelease.yml

@@ -28,7 +28,7 @@ jobs:
             10.x
 
       - name: Install GitVersion
-        uses: gittools/actions/gitversion/setup@v4.2.0
+        uses: gittools/actions/gitversion/setup@v4.5.0
         with:
           versionSpec: '6.x'
 
@@ -76,7 +76,7 @@ jobs:
 
       - name: Determine Version with GitVersion (MSBuild in Proj will do this)
         id:   gitversion
-        uses: gittools/actions/gitversion/execute@v4.2.0
+        uses: gittools/actions/gitversion/execute@v4.5.0
         with:
           useConfigFile: true
           configFilePath: ./GitVersion.yml

Umbraco.Community.UmbNav.Core.Tests/Umbraco.Community.UmbNav.Core.Tests.csproj

@@ -9,7 +9,7 @@
 
   <ItemGroup>
     <PackageReference Include="coverlet.collector" Version="8.0.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.4.0" />
     <PackageReference Include="Moq" Version="4.20.72" />
     <PackageReference Include="xunit" Version="2.9.3" />
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" />

Umbraco.Community.UmbNav.Core/Migrations/UmbNavLegacyModelMigration.cs

@@ -150,24 +150,16 @@ private void ProcessContentType(IContentType contentType)
                     {
                         if (property.PropertyType.PropertyEditorAlias == UmbNavConstants.LegacyEditorAlias)
                         {
-                            var legacyValue = property.GetValue()?.ToString();
-                            if (!string.IsNullOrWhiteSpace(legacyValue))
+                            if (property.PropertyType.VariesByCulture())
                             {
-                                try
+                                foreach (var culture in content.AvailableCultures)
                                 {
-                                    // Example transformation logic; adjust as needed
-                                    var hasTransformed = TryTransformLegacyValue(_logger, legacyValue, out var newValue);
-                                    if (hasTransformed)
-                                    {
-                                        property.SetValue(newValue);
-                                        saveContent = true;
-                                    }
+                                    saveContent |= GetValueAndTryTransform(saveContent, property, culture);
                                 }
-                                catch (Exception ex)
-                                {
-                                    _logger.LogError(ex, "Something went wrong migrating legacy content.{legacyValue}", legacyValue);
-                                }
-
+                            }
+                            else
+                            {
+                                saveContent = GetValueAndTryTransform(saveContent, property, null);
                             }
                         }
                     }
@@ -195,6 +187,31 @@ private void ProcessContentType(IContentType contentType)
 
     }
 
+    private bool GetValueAndTryTransform(bool saveContent, IProperty property, string? culture)
+    {
+        var legacyValue = property.GetValue(culture)?.ToString();
+        if (!string.IsNullOrWhiteSpace(legacyValue))
+        {
+            try
+            {
+                // Example transformation logic; adjust as needed
+                var hasTransformed = TryTransformLegacyValue(_logger, legacyValue, out var newValue);
+                if (hasTransformed)
+                {
+                    property.SetValue(newValue, culture);
+                    saveContent = true;
+                }
+            }
+            catch (Exception ex)
+            {
+                _logger.LogError(ex, "Something went wrong migrating legacy content.{legacyValue}", legacyValue);
+            }
+
+        }
+
+        return saveContent;
+    }
+
     // Add this static readonly field to cache the JsonSerializerOptions instance
     private static readonly JsonSerializerOptions CachedJsonSerializerOptions = new JsonSerializerOptions
     {