Skip to content

Fixed issue where existing items opened the wrong edit modal #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronSadlerUK merged 1 commit into from
May 27, 2026
+15 −2
Merged

Fixed issue where existing items opened the wrong edit modal #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions Umbraco.Community.UmbNav/src/umbnav-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,13 +228,26 @@ export function convertToImageType(image: Guid): ImageItem {
}
}

function normalizeItemType(value: UmbNavLinkPickerLinkType | null | undefined): UmbNavLinkPickerLinkType | null | undefined {
if (!value) return value;
switch (value.toLowerCase()) {
case 'title': return 'Title';
case 'document': return 'Document';
case 'media': return 'Media';
case 'external': return 'External';
default: return value;
}
}

export function ensureNavItemKeys(value: ModelEntryType[]): ModelEntryType[] {
return value.map(item => ({
...item,
key: item.key ?? (uuidv4() as Guid),
unique: item.udi != null && (item.udi.startsWith('umb://document/') || item.udi.startsWith('umb://media/')) ? item.key : undefined,
itemType: item.udi != null && item.udi.startsWith('umb://document/') ? 'Document' :
item.udi != null && item.udi.startsWith('umb://media/') ? 'Media' : item.itemType,
itemType: normalizeItemType(
item.udi != null && item.udi.startsWith('umb://document/') ? 'Document' :
item.udi != null && item.udi.startsWith('umb://media/') ? 'Media' : item.itemType
),
// Always ensure children is an array so nested sorters can initialize
children: Array.isArray(item.children) ? ensureNavItemKeys(item.children) : []
}));
Expand Down