Fix Umbraco V18 Backoffice Compatibility#184
Draft
JBoye wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates draft/publish detection for documents by replacing a backend API enum check with a string-based state comparison.
Changes:
- Removed
DocumentVariantStateModelimport. - Introduced
DRAFT_VARIANT_STATE = "Draft"constant. - Switched
isPublishedlogic to comparedocumentVariant.state(stringified) against the draft constant in two places.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import { UmbControllerHost } from "@umbraco-cms/backoffice/controller-api"; | ||
| import { DocumentVariantStateModel } from "@umbraco-cms/backoffice/external/backend-api"; | ||
|
|
||
| const DRAFT_VARIANT_STATE = "Draft"; |
| let documentVariant = document?.variants?.[0]; | ||
| const documentName = documentVariant?.name ?? null; | ||
| isPublished = documentVariant?.state != DocumentVariantStateModel.DRAFT | ||
| isPublished = String(documentVariant?.state) !== DRAFT_VARIANT_STATE |
| let documentVariant = document?.variants?.[0]; | ||
| const documentName = documentVariant?.name ?? null; | ||
| isPublished = documentVariant?.state != DocumentVariantStateModel.DRAFT | ||
| isPublished = String(documentVariant?.state) !== DRAFT_VARIANT_STATE |
JBoye
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Umbraco V18 DocumentVariantStateModel.Draft was renamed to PublishableVariantStateModel.Draft
This PR uses an fixed enum to keep it compatible with both v17 and v18