Skip to content

fix(core): quality audit — fix docs, validation, tests, and correctness#5

Merged
AbdelStark merged 1 commit intomainfrom
claude/quality-audit-hardening-YWODc
Mar 16, 2026
Merged

fix(core): quality audit — fix docs, validation, tests, and correctness#5
AbdelStark merged 1 commit intomainfrom
claude/quality-audit-hardening-YWODc

Conversation

@AbdelStark
Copy link
Copy Markdown
Owner

  • Fix README: correct license (MIT not Apache 2.0), fix broken quickstart
    (config.init → config.init_model), add architecture section, key concepts,
    status declaration, and development commands
  • Fix lib.rs doc example to compile and run as a doctest
  • Fix visualize_weights example: use op's trained RmsNorm instead of
    creating a fresh one (produced incorrect weight visualization)
  • Add AttnResConfig::validate() with comprehensive checks (d_model > 0,
    num_layers even, d_model divisible by num_heads, dropout in range, etc.)
  • Call validate() in init_model() to catch bad configs at initialization
  • Add AttnResConfig::num_transformer_layers() helper
  • Improve expect() messages in model forward pass
  • Add 9 new tests: two-phase/standard equivalence, Full AttnRes boundary,
    RMSNorm 3D/4D consistency, config validation (good/bad), and more
  • Update CLAUDE.md status from "pre-implementation" to "alpha"
  • Add .env patterns to .gitignore

Total: 57 tests passing, clippy clean, fmt clean.

https://claude.ai/code/session_01NUqHj8Pz1bYNEtzyX3x3kW

- Fix README: correct license (MIT not Apache 2.0), fix broken quickstart
  (config.init → config.init_model), add architecture section, key concepts,
  status declaration, and development commands
- Fix lib.rs doc example to compile and run as a doctest
- Fix visualize_weights example: use op's trained RmsNorm instead of
  creating a fresh one (produced incorrect weight visualization)
- Add AttnResConfig::validate() with comprehensive checks (d_model > 0,
  num_layers even, d_model divisible by num_heads, dropout in range, etc.)
- Call validate() in init_model() to catch bad configs at initialization
- Add AttnResConfig::num_transformer_layers() helper
- Improve expect() messages in model forward pass
- Add 9 new tests: two-phase/standard equivalence, Full AttnRes boundary,
  RMSNorm 3D/4D consistency, config validation (good/bad), and more
- Update CLAUDE.md status from "pre-implementation" to "alpha"
- Add .env patterns to .gitignore

Total: 57 tests passing, clippy clean, fmt clean.

https://claude.ai/code/session_01NUqHj8Pz1bYNEtzyX3x3kW
@AbdelStark AbdelStark merged commit 3708792 into main Mar 16, 2026
4 checks passed
@AbdelStark AbdelStark deleted the claude/quality-audit-hardening-YWODc branch March 17, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants