fix(core): quality audit — fix docs, validation, tests, and correctness#5
Merged
AbdelStark merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
- Fix README: correct license (MIT not Apache 2.0), fix broken quickstart (config.init → config.init_model), add architecture section, key concepts, status declaration, and development commands - Fix lib.rs doc example to compile and run as a doctest - Fix visualize_weights example: use op's trained RmsNorm instead of creating a fresh one (produced incorrect weight visualization) - Add AttnResConfig::validate() with comprehensive checks (d_model > 0, num_layers even, d_model divisible by num_heads, dropout in range, etc.) - Call validate() in init_model() to catch bad configs at initialization - Add AttnResConfig::num_transformer_layers() helper - Improve expect() messages in model forward pass - Add 9 new tests: two-phase/standard equivalence, Full AttnRes boundary, RMSNorm 3D/4D consistency, config validation (good/bad), and more - Update CLAUDE.md status from "pre-implementation" to "alpha" - Add .env patterns to .gitignore Total: 57 tests passing, clippy clean, fmt clean. https://claude.ai/code/session_01NUqHj8Pz1bYNEtzyX3x3kW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(config.init → config.init_model), add architecture section, key concepts,
status declaration, and development commands
creating a fresh one (produced incorrect weight visualization)
num_layers even, d_model divisible by num_heads, dropout in range, etc.)
RMSNorm 3D/4D consistency, config validation (good/bad), and more
Total: 57 tests passing, clippy clean, fmt clean.
https://claude.ai/code/session_01NUqHj8Pz1bYNEtzyX3x3kW