Fix: functionality issue for toggleFocusOnPress
prop and incorrect color issue for focusOnPress
prop in PieChart
component
#1072
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toggleFocusOnPress
functionality issue:selectedIndex
prop is used at few instances inPieChartMain
component andgetPieChartMainProps
function (gifted-charts-core
). One of these instances handlestoggleFocusOnPress
. ButselectedIndex
prop was never included inPieChartMain
component call insidePieChart
component.selectedIndex
prop inPieChartMain
component call insidePieChart
component.fill
prop value for focused pie section at index 0:fill
prop is set to none for the focused pie section.selectedIndex === index
condition wherefill
prop is set to "none".data
prop doesn't include color property for some values, then the color for the focused pie section belonging to those values is set to the color of pie section at index 0.selectedIndex
condition forfill
prop where pie section color is not given.