Skip to content

Conversation

@kuamanet
Copy link

See first the PR on gifted-charts-core

As the other PR, this is not a complete work, it just allows people using typescript in their react native projects to add your library.

Once merged the one on gifted-charts-core we can update the package.json to point to the correct repo (yours)-

@Abhinandan-Kushwaha
Copy link
Owner

Thanks @kuamanet for this valuable PR. Comment here once it is ready from your side.
If you need anything, do let me know. We can connect over Meet or Zoom.

@christophby
Copy link
Contributor

@kuamanet very nice! 🚀
Are you still working on this?

@Vondry
Copy link

Vondry commented May 29, 2024

Hi @kuamanet and @Abhinandan-Kushwaha what is stopping this to be merged? :) I could help you if needed.

@kulak91
Copy link

kulak91 commented Oct 30, 2024

Hi @kuamanet and @Abhinandan-Kushwaha what is stopping this to be merged? :) I could help you if needed.

@Vondry This PR contains a temporary workaround full of 'any' types and one ts-nocheck. I think this should be handled properly instead of using 'any' everywhere

@kuamanet
Copy link
Author

kuamanet commented Nov 5, 2024

@christophby @christophby @kulak91 Sorry, I gave up after Abhinandan-Kushwaha/gifted-charts-core#6 (comment) :/ Feel free to jump-in if you want!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants