Skip to content

Conversation

@OlivieFranklova
Copy link
Collaborator

@OlivieFranklova OlivieFranklova commented May 26, 2025

The entire repository was cleaned up and prepared for development as open source.

Release notes:

  • Add CONTRIBUTING.md
  • Add License headers
  • Add LICENSE.md
  • Add Issue Templates
  • Add release action release_publish
  • Remove Aquasec steps
  • Rename package from africa.absa to za.co.absa
  • update README.md

Closes #1

@OlivieFranklova OlivieFranklova linked an issue May 26, 2025 that may be closed by this pull request
@OlivieFranklova OlivieFranklova self-assigned this May 26, 2025
@github-actions
Copy link

github-actions bot commented May 26, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3 3 100% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
smallfiles/test/init.py 100% 🟢
smallfiles/test/test_version.py 100% 🟢
TOTAL 100% 🟢

updated for commit: df53655 by action🐍

@github-actions
Copy link

github-actions bot commented May 26, 2025

JaCoCo code coverage report - scala 2.12.17

Overall Project 94.54% -26.38% 🍏
Files changed 41.37%

File Coverage
RowsDiff.scala 100%
AnalyseStat.scala 100% 🍏
ColumnsDiff.scala 100%
HashUtils.scala 100% 🍏
Arguments.scala 100%
ArgsParser.scala 100% 🍏
Comparator.scala 99.73% 🍏
IOHandler.scala 98.25% 🍏
OutputFormatType.scala 87.5% -12.5% 🍏
RowByRowAnalysis.scala 87.02% 🍏
DiffComputeType.scala 50% -50%

@github-actions
Copy link

github-actions bot commented May 26, 2025

JaCoCo code coverage report - scala 2.11.12

Overall Project 95.58% -20.69% 🍏
Files changed 41.44%

File Coverage
RowsDiff.scala 100%
AnalyseStat.scala 100% 🍏
ColumnsDiff.scala 100%
HashUtils.scala 100% 🍏
Arguments.scala 100%
ArgsParser.scala 100% 🍏
Comparator.scala 99.77% 🍏
IOHandler.scala 98.83% 🍏
RowByRowAnalysis.scala 89.36% 🍏
OutputFormatType.scala 87.5% -12.5% 🍏
DiffComputeType.scala 40.63% -68.75%

@OlivieFranklova OlivieFranklova requested review from ABMC831 and Copilot and removed request for Copilot May 26, 2025 12:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up the repository in preparation for open source development by updating documentation, workflows, and project structure.

  • Added various documentation files including CONTRIBUTING, LICENSE, and issue templates.
  • Updated YAML workflows for release, CI, and CD while removing Aquasec steps.
  • Renamed the package from "africa.absa" to "za.co.absa" and adjusted related documentation accordingly.

Reviewed Changes

Copilot reviewed 47 out of 53 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
bigfiles/README.md Updated package reference and modified configuration placeholders.
README.md Added an "Abstract example" section and fixed a typo in bullet points.
CONTIBUTING.md Introduced new contributing guidelines (note filename spelling).
.github/workflows/*.yml Added and modified multiple workflows for release, CI & CD.
.github/ISSUE_TEMPLATE/*.md Added new issue templates for spike, bug, feature, epic, and operative tasks.
Files not reviewed (6)
  • LICENSE: Language not supported
  • bigfiles/build.sbt: Language not supported
  • bigfiles/project/Dependencies.scala: Language not supported
  • bigfiles/project/plugins.sbt: Language not supported
  • bigfiles/src/main/scala/africa/absa/cps/analysis/ColumnsDiff.scala: Language not supported
  • bigfiles/src/main/scala/africa/absa/cps/analysis/RowsDiff.scala: Language not supported

@@ -0,0 +1,36 @@
# How to Contribute?
Copy link

Copilot AI May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name 'CONTIBUTING.md' appears to be misspelled; consider renaming it to 'CONTRIBUTING.md' to align with common conventions.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines 58 to 59
cp target/scala-${{ matrix.scalaShort }}/dataset-comparison-*.jar staging/scala-${{ matrix.scalaShort }}$base_name
echo "artifact_name=scala-${{ matrix.scalaShort }}$base_name" >> $GITHUB_ENV
Copy link

Copilot AI May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a separator between '${{ matrix.scalaShort }}' and '$base_name' (e.g., using a dash) to improve the clarity of the artifact name.

Suggested change
cp target/scala-${{ matrix.scalaShort }}/dataset-comparison-*.jar staging/scala-${{ matrix.scalaShort }}$base_name
echo "artifact_name=scala-${{ matrix.scalaShort }}$base_name" >> $GITHUB_ENV
cp target/scala-${{ matrix.scalaShort }}/dataset-comparison-*.jar staging/scala-${{ matrix.scalaShort }}-$base_name
echo "artifact_name=scala-${{ matrix.scalaShort }}-$base_name" >> $GITHUB_ENV

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@OlivieFranklova OlivieFranklova merged commit f367000 into master May 26, 2025
7 checks passed
@OlivieFranklova OlivieFranklova deleted the feature/1-clean-up-and-open-source branch May 26, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up and open source

3 participants