-
Notifications
You must be signed in to change notification settings - Fork 0
Clean up this repository #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
JaCoCo code coverage report - scala 2.12.17
|
JaCoCo code coverage report - scala 2.11.12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR cleans up the repository in preparation for open source development by updating documentation, workflows, and project structure.
- Added various documentation files including CONTRIBUTING, LICENSE, and issue templates.
- Updated YAML workflows for release, CI, and CD while removing Aquasec steps.
- Renamed the package from "africa.absa" to "za.co.absa" and adjusted related documentation accordingly.
Reviewed Changes
Copilot reviewed 47 out of 53 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| bigfiles/README.md | Updated package reference and modified configuration placeholders. |
| README.md | Added an "Abstract example" section and fixed a typo in bullet points. |
| CONTIBUTING.md | Introduced new contributing guidelines (note filename spelling). |
| .github/workflows/*.yml | Added and modified multiple workflows for release, CI & CD. |
| .github/ISSUE_TEMPLATE/*.md | Added new issue templates for spike, bug, feature, epic, and operative tasks. |
Files not reviewed (6)
- LICENSE: Language not supported
- bigfiles/build.sbt: Language not supported
- bigfiles/project/Dependencies.scala: Language not supported
- bigfiles/project/plugins.sbt: Language not supported
- bigfiles/src/main/scala/africa/absa/cps/analysis/ColumnsDiff.scala: Language not supported
- bigfiles/src/main/scala/africa/absa/cps/analysis/RowsDiff.scala: Language not supported
| @@ -0,0 +1,36 @@ | |||
| # How to Contribute? | |||
Copilot
AI
May 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file name 'CONTIBUTING.md' appears to be misspelled; consider renaming it to 'CONTRIBUTING.md' to align with common conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
| cp target/scala-${{ matrix.scalaShort }}/dataset-comparison-*.jar staging/scala-${{ matrix.scalaShort }}$base_name | ||
| echo "artifact_name=scala-${{ matrix.scalaShort }}$base_name" >> $GITHUB_ENV |
Copilot
AI
May 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider adding a separator between '${{ matrix.scalaShort }}' and '$base_name' (e.g., using a dash) to improve the clarity of the artifact name.
| cp target/scala-${{ matrix.scalaShort }}/dataset-comparison-*.jar staging/scala-${{ matrix.scalaShort }}$base_name | |
| echo "artifact_name=scala-${{ matrix.scalaShort }}$base_name" >> $GITHUB_ENV | |
| cp target/scala-${{ matrix.scalaShort }}/dataset-comparison-*.jar staging/scala-${{ matrix.scalaShort }}-$base_name | |
| echo "artifact_name=scala-${{ matrix.scalaShort }}-$base_name" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
The entire repository was cleaned up and prepared for development as open source.
Release notes:
africa.absatoza.co.absaCloses #1