Skip to content

(#154) Set Groups and Case Sensitivity to optional Parameters #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TheLydonKing wants to merge 2 commits into
base: master
Choose a base branch
from
Open

(#154) Set Groups and Case Sensitivity to optional Parameters #155

TheLydonKing wants to merge 2 commits into from

Conversation

@TheLydonKing
Copy link
Collaborator

@TheLydonKing TheLydonKing commented Dec 3, 2025

Release Notes:

  • Removed overloaded methods and introduced AuthMethod trait to indicate authentication method. This removes ambiguity with the default parameters and avoids compilation errors.

Closes: #154

@TheLydonKing TheLydonKing self-assigned this Dec 3, 2025
@TheLydonKing TheLydonKing requested a review from dk1844 as a code owner December 3, 2025 09:38
@TheLydonKing TheLydonKing added the enhancement New feature or request label Dec 3, 2025
@TheLydonKing TheLydonKing linked an issue Dec 3, 2025 that may be closed by this pull request
Set Groups and Case sensitivity for token retrieval in client lib as optional #154
Open
@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

Report: Report: clientLibrary - scala:2.12.17

Metric (instruction) Coverage Threshold Status
Overall 45.58% 43.0% ✅
Changed Files 32.02% 70.0% ❌
File Path Coverage Threshold Status
AuthMethod.scala 50.0% 0.0% ✅
TokenRetrievalClient.scala 14.03% 0.0% ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dk1844 dk1844 Awaiting requested review from dk1844 dk1844 is a code owner

@jakipatryk jakipatryk Awaiting requested review from jakipatryk jakipatryk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@TheLydonKing TheLydonKing

Labels

enhancement New feature or request tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set Groups and Case sensitivity for token retrieval in client lib as optional

2 participants

@TheLydonKing