Skip to content

refactor: move the AWS RUM sink into the core's rum entry point - #50

Merged
fateeand merged 20 commits into
mainfrom
split/6-rum
Nov 18, 2026
Merged

fateeand merged 20 commits into
mainfrom
split/6-rum

Conversation

@fateeand

@fateeand fateeand commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Part 6 of 8 of the split of #34. It moves the AWS RUM sink into the core's /rum entry point, and the Angular /rum entry becomes a thin subclass.

Changes

  • @absaoss-cps/ui-watchtower/rum: the RUM sink; aws-rum-web is an optional peer, loaded lazily.
  • The Angular /rum entry extends it with DI.
  • A spec runs the Angular package's private copy of a few helpers and the main entry's copy side by side, so they can't drift.
  • Core coverage reaches 90% on every metric, and npm run test:coverage now fails below that.

How to review

Mostly moved files (31 files). The behaviour of the sink is unchanged.

Closes #42

Part 6 of 8 of the epic #35. Stack on GitHub, merged bottom first:

  1. test: add API, type and wire-protocol safety nets #45 Safety nets
  2. build: add the framework-independent core package #46 Scaffold the core
  3. refactor: move models, redaction and scenarios into the core #47 Move models, redaction and scenarios
  4. refactor: add the framework-independent telemetry engine #48 Telemetry engine
  5. refactor: move the shell/fragment broadcast protocol into the core #49 Broadcast protocol
  6. refactor: move the AWS RUM sink into the core's rum entry point #50 RUM sink (this PR)
  7. test: smoke-test the packed packages in real consumers #51 Smoke tests
  8. feat: release and publish both packages independently, with docs and logos #52 Release, docs and logos

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements
99.23% (+4.63% 🔼)
258/260
🟢 Branches
96.67% (+4.68% 🔼)
58/60
🟢 Functions
98.61% (+3.72% 🔼)
71/72
🟢 Lines
99.57% (+4.15% 🔼)
234/235
Show files with reduced coverage 🔻
St.❔
File Statements Branches Functions Lines
🟢
... / uwt-rum-telemetry.sink.ts
100% (+3.5% 🔼)
50% (-43.37% 🔻)
100% (+4.76% 🔼)
100% (+2.51% 🔼)

Test suite run success

544 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 2c2cf6e

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Core coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 98.61% 1344/1363
🟢 Branches 94.95% 808/851
🟢 Functions 98.52% 332/337
🟢 Lines 98.87% 1318/1333

Test suite run success

420 tests passing in 22 suites.

Report generated by 🧪jest coverage report action from 2c2cf6e

Base automatically changed from split/5-broadcast to main November 16, 2026 16:05
# Conflicts:
#	projects/ui-watchtower/src/lib/sinks/uwt-broadcast/uwt-broadcast.spec.ts
Comment thread projects/ui-watchtower/README.md Resolved
@fateeand
fateeand merged commit e3571df into main Nov 18, 2026
9 checks passed
@fateeand
fateeand deleted the split/6-rum branch November 18, 2026 10:12
fateeand added a commit that referenced this pull request Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move the AWS RUM sink into the core's rum entry point

2 participants