-
Notifications
You must be signed in to change notification settings - Fork 0
Fix Aquasec alerts #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JaCoCo code coverage report - scala 2.12.18
|
lsulak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review done from my side, just a tiny thing or two to finish this 'theme' here, otherwise LGTM, as expected and according to our recent chat
miroslavpojer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
| - cron: '0 0 * * *' | ||
|
|
||
| jobs: | ||
| check: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this file, it's now part of Github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand this comment. Are you asking to remove file dependent_items.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. No longer needed, similar behavior now provides Github, they added it as a build-in feature now instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in a9dc359.
.github/dependabot.yml
Outdated
| prefix: "chore" | ||
| include: "scope" | ||
|
|
||
| - package-ecosystem: "sbt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this section - dependabot doesn't support sbt yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in a9dc359.
Release Notes:
Close #50