Fix Pybind11 Imath Frustum #459
Merged
+44
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
cary-ilm
requested changes
Dec 17, 2024
Member
cary-ilm
left a comment
cary-ilm
left a comment
There was a problem hiding this comment.
Thanks for the speedy response, and yes, the previous PR replaced the Imath:: with ``IMATH_NAMESPACE::` to support the case where Imath is built with a custom namespace.
Looks like the template is still not quite right here.
| c.def(pybind11::init<>(), "Uninitialized by default") | ||
| .def(pybind11::init<T>(), pybind11::arg("frustum"), "Copy constructor") | ||
| .def(pybind11::init<S>(), pybind11::arg("nearPlane"), pybind11::arg("farPlane"), pybind11::arg("fovx"), pybind11::arg("aspect"), "Initialize with basic frustum properties") | ||
| .def(pybind11::init<const S, S, S, S>(), pybind11::arg("nearPlane"), pybind11::arg("farPlane"), pybind11::arg("fovx"), pybind11::arg("aspect"), "Initialize with basic frustum properties") |
Member
There was a problem hiding this comment.
nearPlane, farPlane, fovx, and aspect are float/double, but S in this context is M44f/M44d, right?
Signed-off-by: Todica Ionut <[email protected]>
Member
|
Looks like you added a 4th argument to the template instantiation but not the declaration, the build is still failing. Is this somehow compiling on your end? |
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Signed-off-by: Todica Ionut <[email protected]>
Contributor
Author
|
Ci temporarily:
@cary-ilm I merged. CI checks failed |
cary-ilm
approved these changes
Dec 19, 2024
Member
cary-ilm
left a comment
cary-ilm
left a comment
There was a problem hiding this comment.
This gets the build working again, I'm going to merge as is. I'll be away from the project Dec 19-Jan 12, but can help resolve the issues after that.
Treata11
pushed a commit
to Treata11/Imath
that referenced
this pull request
Apr 18, 2025
* Imath Frustum to IMATH_NAMESPACE Signed-off-by: Todica Ionut <[email protected]> * Imath Euler to IMATH_NAMESPACE Signed-off-by: Todica Ionut <[email protected]> * Remove Signed-off-by: Todica Ionut <[email protected]> * Restore Signed-off-by: Todica Ionut <[email protected]> * Frustum class S Signed-off-by: Todica Ionut <[email protected]> * Frustum remove class M Signed-off-by: Todica Ionut <[email protected]> * bug fix Signed-off-by: Todica Ionut <[email protected]> * bug fix Signed-off-by: Todica Ionut <[email protected]> * bug fix Signed-off-by: Todica Ionut <[email protected]> * bug fix Signed-off-by: Todica Ionut <[email protected]> * bug fix Signed-off-by: Todica Ionut <[email protected]> * bug fix Signed-off-by: Todica Ionut <[email protected]> * add float double Signed-off-by: Todica Ionut <[email protected]> * remove Frustum Signed-off-by: Todica Ionut <[email protected]> * remove Frustum Signed-off-by: Todica Ionut <[email protected]> * remove PyBind Imath Frustum Signed-off-by: Todica Ionut <[email protected]> * remove Euler Signed-off-by: Todica Ionut <[email protected]> * remove Euler Signed-off-by: Todica Ionut <[email protected]> * remove Euler pybind test Signed-off-by: Todica Ionut <[email protected]> --------- Signed-off-by: Todica Ionut <[email protected]> Signed-off-by: Treata11 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not working