use cmake default variable for PYTHON_INSTALL_DIR #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
AFAICT, this returns an absolute path. For relocatable installs, one wants a relative one, like the one present. |
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
Nov 17, 2025
Python3_SIETARCH is relative, but PYTHON_INSTALL_DIR is absolute. So strip the Python3_PREFIS from Python3_SITEARCH to form a relative path. This is preferable to the current hardcoded path, but is also preferable to using an absolute path, as suggested in AcademySoftwareFoundation#523. Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
Nov 17, 2025
Python3_SIETARCH is relative, but PYTHON_INSTALL_DIR is absolute. So strip the Python3_PREFIS from Python3_SITEARCH to form a relative path. This is preferable to the current hardcoded path, but is also preferable to using an absolute path, as suggested in AcademySoftwareFoundation#523. Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
Nov 17, 2025
Python3_SIETARCH is relative, but PYTHON_INSTALL_DIR is absolute. So strip the Python3_PREFIS from Python3_SITEARCH to form a relative path. This is preferable to the current hardcoded path, but is also preferable to using an absolute path, as suggested in AcademySoftwareFoundation#523. Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
pushed a commit
to cary-ilm/Imath
that referenced
this pull request
Nov 17, 2025
Python3_SIETARCH is relative, but PYTHON_INSTALL_DIR is absolute. So strip the Python3_PREFIS from Python3_SITEARCH to form a relative path. This is preferable to the current hardcoded path, but is also preferable to using an absolute path, as suggested in AcademySoftwareFoundation#523. Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
pushed a commit
to cary-ilm/Imath
that referenced
this pull request
Nov 17, 2025
Python3_SIETARCH is relative, but PYTHON_INSTALL_DIR is absolute. So strip the Python3_PREFIS from Python3_SITEARCH to form a relative path. This is preferable to the current hardcoded path, but is also preferable to using an absolute path, as suggested in AcademySoftwareFoundation#523. Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
pushed a commit
to cary-ilm/Imath
that referenced
this pull request
Nov 17, 2025
Python3_SIETARCH is relative, but PYTHON_INSTALL_DIR is absolute. So strip the Python3_PREFIS from Python3_SITEARCH to form a relative path. This is preferable to the current hardcoded path, but is also preferable to using an absolute path, as suggested in AcademySoftwareFoundation#523. Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
Nov 25, 2025
* Set PYTHON_INSTALL_DIR based on Python3_SITEARCH Python3_SIETARCH is relative, but PYTHON_INSTALL_DIR is absolute. So strip the Python3_PREFIS from Python3_SITEARCH to form a relative path. This is preferable to the current hardcoded path, but is also preferable to using an absolute path, as suggested in #523. Signed-off-by: Cary Phillips <[email protected]> * Update src/pybind11/PyBindImath/CMakeLists.txt Co-authored-by: Copilot <[email protected]> Signed-off-by: Cary Phillips <[email protected]> * Update src/python/CMakeLists.txt Co-authored-by: Copilot <[email protected]> Signed-off-by: Cary Phillips <[email protected]> --------- Signed-off-by: Cary Phillips <[email protected]> Co-authored-by: Funda Wang <[email protected]> Co-authored-by: Copilot <[email protected]>
Member
|
Closing this in favor of #528. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cmake.org/cmake/help/latest/module/FindPython3.html
cmake output
Python3_SITEARCHvariable for installation. Using this as default value seems more safe than current hardcode path.