Fix token handling in functional nodegraphs#2363
Merged
jstone-lucasfilm merged 1 commit intoMay 3, 2025
Merged
Conversation
…und during token search. Add in updated token test.
jstone-lucasfilm
approved these changes
May 3, 2025
jstone-lucasfilm
left a comment
Member
There was a problem hiding this comment.
This looks like a good change to me, thanks @kwokcb!
655bd40
into
AcademySoftwareFoundation:main
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Tokens on
nodedefs are not checked when resolving inputs on nodes in a functional nodegraph.Update: #2361
Change
Patch token search to check
nodedeftokens when applying token resolutionTest
Modified existing token test and added in
nodedefcase.Example below is evaluation of an instance of a definition using tokens to resolve the input file name to an unlit shader. The token is the image name.