Skip to content

Fix failing hextile unit testing#2374

Merged
ld-kerley merged 6 commits into
AcademySoftwareFoundation:mainfrom
ld-kerley:remove-hextile-test-skipping-for-msl-and-add-render-test-skip-for-osl
May 8, 2025
Merged

Fix failing hextile unit testing#2374
ld-kerley merged 6 commits into
AcademySoftwareFoundation:mainfrom
ld-kerley:remove-hextile-test-skipping-for-msl-and-add-render-test-skip-for-osl

Conversation

@ld-kerley

Copy link
Copy Markdown
Contributor

The recent addition of an example hextile unit test is currently failing the OSL render tests. The do not run in CI because of the time it takes to build OSL - so this failure was not caught during the merge checks.

This PR adds a filtering mechanism to the render tests, similar to the shader generation tests, to allow for specific files to be excluded for render testing. The hextile tests are then excluded from OSL render testing, as that node has not yet been implemented.

Also removing the hextile exclusion for shader generation for MSL.

…ation for MSL.

Adds mechanism to skip files during render tests in a similar way, and add the hextile to be skipped for OSL.
@ld-kerley ld-kerley requested a review from masuosuzuki May 8, 2025 16:00
@jstone-lucasfilm jstone-lucasfilm changed the title Fix failing hextile unit testing. Improvements to hextile language support May 8, 2025
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>

@jstone-lucasfilm jstone-lucasfilm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @ld-kerley!

In order to maintain the accuracy of our new target support documentation, should we remove MSL from the list of unsupported platforms for hextiledimage and hextilednormalmap here?

https://github.com/AcademySoftwareFoundation/MaterialX/tree/main/libraries#target-support

@ld-kerley

Copy link
Copy Markdown
Contributor Author

Sure thing - I can update that document - I always forget it even exists - as we were discussing in the TSC I think we need to find a way to consolidate this information with the spec.

Also I'm going to revert the title of the PR - as I am not changing the language support available in the codebase here at all - I'm just modifying the test setup so it doesn't fail.

@ld-kerley ld-kerley changed the title Improvements to hextile language support Fix failing hextile unit testing May 8, 2025
@msuzuki-nvidia

Copy link
Copy Markdown
Contributor

Yes thank you for doing this @ld-kerley, it looks good to me too!

@ld-kerley ld-kerley merged commit ec0955e into AcademySoftwareFoundation:main May 8, 2025
32 checks passed
@jstone-lucasfilm

Copy link
Copy Markdown
Member

@ld-kerley That original title doesn't follow our conventions on the MaterialX project, especially with that final period that goes against common GitHub practice, but it's too late now! :D

@ld-kerley ld-kerley deleted the remove-hextile-test-skipping-for-msl-and-add-render-test-skip-for-osl branch November 21, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants