Skip to content

Fix MSVC warnings #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jstone-lucasfilm merged 3 commits into from
May 24, 2025
Merged

Fix MSVC warnings #2408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a15dc73
Fix MSVC warnings
jstone-lucasfilm May 22, 2025
4e974ef
Merge branch 'main' into main
jstone-lucasfilm May 23, 2025
40186cc
Merge branch 'main' into main
jstone-lucasfilm May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/MaterialXRender/ShaderRenderer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class MX_RENDER_API ShaderRenderer
/// @{

/// Capture the current rendered output as an image.
virtual ImagePtr captureImage(ImagePtr image = nullptr)
virtual ImagePtr captureImage(ImagePtr = nullptr)
{
return nullptr;
}
Expand Down
2 changes: 1 addition & 1 deletion source/MaterialXTest/MaterialXGenShader/GenShaderUtil.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ class ShaderGeneratorTester
void validate(const mx::GenOptions& generateOptions, const std::string& optionsFilePath);

// Allow the tester to alter the document, e.g., by flattening file names.
virtual void preprocessDocument(mx::DocumentPtr doc) {};
virtual void preprocessDocument(mx::DocumentPtr) {};

// Compile generated source code. Default implementation does nothing.
virtual void compileSource(const std::vector<mx::FilePath>& /*sourceCodePaths*/) {};
Expand Down
2 changes: 1 addition & 1 deletion source/MaterialXTest/MaterialXRender/RenderUtil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ void ShaderRenderTester::getGenerationOptions(const GenShaderUtil::TestSuiteOpti
void ShaderRenderTester::printRunLog(const RenderProfileTimes &profileTimes,
const GenShaderUtil::TestSuiteOptions& options,
std::ostream& stream,
mx::DocumentPtr dependLib)
mx::DocumentPtr)
{
profileTimes.print(stream);

Expand Down