Add support for time and frame in web viewer#2419
Merged
jstone-lucasfilm merged 1 commit intoJun 1, 2025
Merged
Conversation
jstone-lucasfilm
approved these changes
Jun 1, 2025
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
Member
There was a problem hiding this comment.
This looks like a good improvement to me, thanks @hybridherbst!
jstone-lucasfilm
merged commit aabfa76
into
AcademySoftwareFoundation:main
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time is currently calculated based on the time at the start of the frame, in seconds – so not framecount / FPS as per the spec, but the more useful calculation in real-time settings (related: #2417)
This should be the last piece missing to fix
time_floatandframe_floatdo not have any effect #1952.