Allow keyboard deletion of selected links in Graph Editor#2426
Merged
jstone-lucasfilm merged 1 commit intoJun 1, 2025
Merged
Conversation
jstone-lucasfilm
approved these changes
Jun 1, 2025
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
Member
There was a problem hiding this comment.
Thanks for this improvement, @hybridherbst!
jstone-lucasfilm
changed the title
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit ad94922
into
AcademySoftwareFoundation:main
32 checks passed
Contributor
Author
|
Thanks! After submitting this PR I ran into a few cases where seemingly the wrong thing got deleted when pressing "delete" while having an edge selected, so now I'm not super sure anymore about the Link ID logic being correct here. Although from the code I don't know how it can be wrong. In other words: would be great if someone else could also take a look to verify the code. |
Member
|
If you know of specific cases where deletion behaves incorrectly with links, I'd recommend posting a GitHub Issue for them, and we can focus developers on those issues next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to delete selected links using the keyboard, same as it works for nodes.
The existing functionality to Option-Click on a link is still the same, but now deletion of links should be more discoverable.
Personally I only found Option-click by looking at the code while trying to understand how I can delete links; the obvious select-and-press-delete hadn't worked, with this PR it does.