Fix uninitialized member variable in MetalState#2884
Merged
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom May 6, 2026
Merged
Fix uninitialized member variable in MetalState#2884jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
warrenm
changed the title
jstone-lucasfilm
approved these changes
May 6, 2026
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks like a correct fix to me, and the missing initializer in some MacOS environments was a valid bug. Thanks @warrenm!
jstone-lucasfilm
merged commit 3811688
into
AcademySoftwareFoundation:main
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to address issue #1518.
I believe the first part of this issue to be obsolete. The CMake targets have changed substantially since the issue was reported, and I was able to build with Xcode 12.4 on macOS Catalina 10.15.8 without errors.
The second part of the issue is still relevant. When compiled on a system with a macOS 11+ SDK but running on an OS version prior to macOS 11, the
supportsTiledPipelinemember variable is not initialized by the constructor or theinitialize()method, and can hold an invalid value. This doesn't cause a crash because of further runtime checks ininitLinearToSRGBKernel(), but it does raise a runtime issue when compiled with UBSAN.These changes ensure that the
supportsTiledPipelinevariable is always initialized, regardless of SDK version or OS version.Tested on macOS Catalina 10.15.8 with Xcode 12.4 and macOS Tahoe 26.4.1 with Xcode 26.4.1.