Add /bigobj for pybind11 target on Windows#2304
Open
remia wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
Add /bigobj for pybind11 target on Windows#2304remia wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
remia wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Rémi Achard <remiachard@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #2279, I tried to reproduce on my Windows box before fixing but unfortunately wasn't able to trigger the issue with a local install of PyBind11 3.0.3. This change simply copy the code from Installpybind11.cmake, as always these issues come from the fact we create our imported targets manually (see #1638).