[rust/rqd] Fix memory bug on OOM killed frames #2093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a frame is killed due to OOM, it is possible the that thread that collects stats before reporting back races the frame wrapping process and gather stats for the frame when some of its procs have died, leading to a incorrect reading of memory for the given frame.
How the bug manifests:
For successful frames:**
refresh_procsupdates stats normallyFor killed frames (OOM):
kill_session()is called → child processes start dyingrefresh_procs()cycle happens (this runs every report interval)session_processes.clear()wipes out all the cached process data including the high memory readingscollect_proc_stats()now reads only the session leader's memory (typically very small, just the shell wrapper)