SG-40829: Better about box #1000
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Bergeron <[email protected]>
pbergeron-adsk
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
…files section Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: pbergeron-adsk <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
bernie-laberge
approved these changes
Dec 2, 2025
Contributor
bernie-laberge
left a comment
bernie-laberge
left a comment
There was a problem hiding this comment.
LGTM
Thank you @pbergeron-adsk !
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
Contributor
|
I forgot to ask while I was reviewing earlier, but why weren't you able to test this for Open RV? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
SG-40829
note: needs OTIO version found in python3.cmake file
Summarize your change.
The current RV/OpenRV dialog box is really plain, it barely shows the current build hash, but that's basically it. It used to be, in the days before OpenRV, that the about box contained all the info about the dependencies and third party components. This was linked to a build system that was overhauled when going OpenRV, and it never got fixed.
Instead of bringing the old code back, because we have a new build system anyway, we re-developed the feature from scratch.
During the build phase, a new about_rv.cpp file is created from a python script executed from within the makefiles, which basically just exports a html string containing the information of the build variables.
NOTE: I apologize for the auto-reformatting that happens in the cmake files when committing. There isn't much I can do about this, it makes the actual changes very hard to find... :(
Describe the reason for the change.
From a QA perspective, this is much better to be able to identify a build version.
Describe what you have tested and on which operating system.
macOS, for RV-only.
Even though it should work just fine, this really needs to be tested for an OpenRV build, and on Windows/Linux too.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.