Skip to content

Fix: Use RV's python version to build wheels #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2025
Merged

Fix: Use RV's python version to build wheels #1009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b61324
Fix: Use RV's python version to build wheels
rogernelson Dec 1, 2025
2448510
Unifying otio build params across OSes
rogernelson Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 30 additions & 28 deletions cmake/dependencies/python3.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,14 @@ ELSE() # Not WINDOWS
)
ENDIF()

# Set the appropriate library for CMAKE_ARGS based on platform
# Windows needs the import library (.lib), Unix needs the shared library (.so/.dylib)
IF(RV_TARGET_WINDOWS)
SET(_python3_cmake_library ${_python3_implib})
ELSE()
SET(_python3_cmake_library ${_python3_lib})
ENDIF()

# Generate requirements.txt from template with the OpenTimelineIO version substituted
SET(_requirements_input_file
"${PROJECT_SOURCE_DIR}/src/build/requirements.txt.in"
Expand All @@ -258,37 +266,31 @@ CONFIGURE_FILE(
@ONLY
)

IF(RV_TARGET_WINDOWS)
# On Windows, OpenTimelineIO needs to be built from source and requires
# CMake to find the Python libraries. Set CMAKE_ARGS to help pybind11
# locate the Python development files.
# This is required for both old and new versions of pybind11, but especially
# for pybind11 v2.13.6+ which has stricter Python library detection.
# Note: pybind11's FindPythonLibsNew.cmake uses PYTHON_LIBRARY (all caps),
# PYTHON_INCLUDE_DIR, and PYTHON_EXECUTABLE variables.

IF(CMAKE_BUILD_TYPE MATCHES "^Debug$")
# For Debug builds, we need to tell OpenTimelineIO to build in debug mode
# and link against the debug Python library (python311_d.lib)
SET(_requirements_install_command
${CMAKE_COMMAND} -E env
"OTIO_CXX_DEBUG_BUILD=1"
"CMAKE_ARGS=-DPYTHON_LIBRARY=${_python3_implib} -DPYTHON_INCLUDE_DIR=${_include_dir} -DPYTHON_EXECUTABLE=${_python3_executable}"
"${_python3_executable}" -m pip install --upgrade -r "${_requirements_output_file}"
)
ELSE()
SET(_requirements_install_command
${CMAKE_COMMAND} -E env
"CMAKE_ARGS=-DPYTHON_LIBRARY=${_python3_implib} -DPYTHON_INCLUDE_DIR=${_include_dir} -DPYTHON_EXECUTABLE=${_python3_executable}"
"${_python3_executable}" -m pip install --upgrade -r "${_requirements_output_file}"
)
ENDIF()
# OpenTimelineIO needs to be built from source with CMAKE_ARGS to ensure it uses
# the correct custom-built Python libraries. This is required for both old and new
# versions of pybind11, especially pybind11 v2.13.6+ which has stricter detection.
# Note: pybind11's FindPythonLibsNew.cmake uses PYTHON_LIBRARY (all caps),
# PYTHON_INCLUDE_DIR, and PYTHON_EXECUTABLE variables.
# --no-cache-dir: Don't use pip's wheel cache (prevents using wheels built for wrong Python version)
# --force-reinstall: Reinstall packages even if already installed (ensures fresh build)

# Set OTIO_CXX_DEBUG_BUILD for all Debug builds to ensure OTIO's C++ extensions
# are built with debug symbols and proper optimization levels matching RV's build type.
# On Windows, this also ensures OTIO links against the debug Python library (python311_d.lib).
IF(CMAKE_BUILD_TYPE MATCHES "^Debug$")
SET(_otio_debug_env "OTIO_CXX_DEBUG_BUILD=1")
ELSE()
SET(_requirements_install_command
"${_python3_executable}" -m pip install --upgrade -r "${_requirements_output_file}"
)
SET(_otio_debug_env "")
ENDIF()

# Single unified command for all platforms and build types
SET(_requirements_install_command
${CMAKE_COMMAND} -E env
${_otio_debug_env}
"CMAKE_ARGS=-DPYTHON_LIBRARY=${_python3_cmake_library} -DPYTHON_INCLUDE_DIR=${_include_dir} -DPYTHON_EXECUTABLE=${_python3_executable}"
"${_python3_executable}" -m pip install --upgrade --no-cache-dir --force-reinstall -r "${_requirements_output_file}"
)

IF(RV_TARGET_WINDOWS)
SET(_patch_python_command
"patch -p1 < ${CMAKE_CURRENT_SOURCE_DIR}/patch/python-${RV_DEPS_PYTHON_VERSION}/python.${RV_DEPS_PYTHON_VERSION}.openssl.props.patch &&\
Expand Down
Loading