Skip to content

Conversation

@rogernelson
Copy link
Contributor

Build all python dependencies from source

Summarize your change.

After fixing ABI compatibility issues with OTIO arising from the fact that we are building our own custom python, I checked the other packages and there are indeed others that also have binary components (PyOpenGL_accelerate, pydantic, and cryptography).

Because of this, we should just always build the packages from source with the same compiler we use to build python, and we can do that using the --no-binary option from pip. Although this might be a little bit slower, it will ensure that any package with binary components won't have ABI compatibility issues and for pure python packages it has no effect anyway.

Describe the reason for the change.

ABI safety

Describe what you have tested and on which operating system.

Built on Mac OS 26.1.

Copy link
Contributor

@pbergeron-adsk pbergeron-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@bernie-laberge bernie-laberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants