SG-34355 - Fix wrong TIFF compression being displayed #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chenl1 <[email protected]>
chenlj1
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
|
|
chenlj1
changed the title
bernie-laberge
approved these changes
Jan 9, 2026
Contributor
bernie-laberge
left a comment
bernie-laberge
left a comment
There was a problem hiding this comment.
Well done !
Thank you @chenlj1 !
eloisebrosseau
approved these changes
Jan 9, 2026
cedrik-fuoco-adsk
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SG-34355: RV is not returning proper compression information of TIFF files anymore
Summarize your change.
Made sure the compression variable is the same type as the one used to store the compression type (changed to unsigned short from unsigned int) so it is consistent with the function it is used with. Added TIFFTAG_COMPRESSION to the list of tags that we handle manually.
Describe the reason for the change.
Previously, the TIFFTAG_COMPRESSION was being overwritten every time we call readAllTags() causing the compression type to be a numerical value instead of the actual compression name.
Describe what you have tested and on which operating system.
This fix was tested on macOS with Tiff sequences compressed using LZW and RLE.
If possible, provide screenshots.
Under TIFF/Compression, the correct compression type is displayed instead of a number.