Make saveFileDialog RV command permissions check optional #1056
+27
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernard Laberge <[email protected]>
bernie-laberge
requested review from
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make saveFileDialog RV command permissions check optional
Linked issues
NA
Describe the reason for the change.
Some Windows users reported that when using the saveFileDialog() RV command and writing on a network drive with the appropriate write permissions, RV was incorrectly reporting that the destination directory was not writable by the user. We were not able to reproduce this issue which would have allowed us to find the real cause of this issue.
Summarize your change.
This commit makes the saveFileDialog RV command permissions check prior to saving optional if the RV_SKIP_SAVE_FILE_DIALOG_PERMISSIONS_CHECK environment variable is set and also adds a "Try to Save Anyway" button if the permission check fails.
Note that if the directory of the saving operation is really not writable, then the write operation will fail.
At least this will unblock users facing this issue which seams to be Windows + Network drive specific.
Describe what you have tested and on which operating system.
Successfuly tested by the Windows users facing this specific Windows + Network drive issue.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.