Skip to content

fix: SG-44617: Build imgui with custom RV_DEPS_BASE_DIR #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulbarton90 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −8
Open

fix: SG-44617: Build imgui with custom RV_DEPS_BASE_DIR #1367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions cmake/dependencies/imgui.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ EXTERNALPROJECT_ADD(
GIT_TAG ${RV_DEPS_IMPLOT_TAG}
DOWNLOAD_DIR ${RV_DEPS_DOWNLOAD_DIR}
DOWNLOAD_EXTRACT_TIMESTAMP TRUE
SOURCE_DIR ${CMAKE_BINARY_DIR}/${_target}/deps/implot
SOURCE_DIR ${_base_dir}/deps/implot
CONFIGURE_COMMAND ""
BUILD_COMMAND ""
INSTALL_COMMAND ""
Expand All @@ -71,7 +71,7 @@ EXTERNALPROJECT_ADD(
GIT_TAG ${RV_DEPS_IMGUI_BACKEND_QT_TAG}
DOWNLOAD_DIR ${RV_DEPS_DOWNLOAD_DIR}
DOWNLOAD_EXTRACT_TIMESTAMP TRUE
SOURCE_DIR ${CMAKE_BINARY_DIR}/${_target}/deps/imgui-backend-qt
SOURCE_DIR ${_base_dir}/deps/imgui-backend-qt
CONFIGURE_COMMAND ""
BUILD_COMMAND ""
INSTALL_COMMAND ""
Expand All @@ -87,7 +87,7 @@ EXTERNALPROJECT_ADD(
GIT_TAG ${RV_DEPS_IMGUI_NODE_EDITOR_TAG}
DOWNLOAD_DIR ${RV_DEPS_DOWNLOAD_DIR}
DOWNLOAD_EXTRACT_TIMESTAMP TRUE
SOURCE_DIR ${CMAKE_BINARY_DIR}/${_target}/deps/imgui-node-editor
SOURCE_DIR ${_base_dir}/deps/imgui-node-editor
CONFIGURE_COMMAND ""
BUILD_COMMAND ""
INSTALL_COMMAND ""
Expand Down Expand Up @@ -120,12 +120,11 @@ EXTERNALPROJECT_ADD(
DOWNLOAD_NAME ${_target}_${_version}.zip
DOWNLOAD_DIR ${RV_DEPS_DOWNLOAD_DIR}
DOWNLOAD_EXTRACT_TIMESTAMP TRUE
SOURCE_DIR ${CMAKE_BINARY_DIR}/${_target}/src
SOURCE_DIR ${_base_dir}/src
PATCH_COMMAND
${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_SOURCE_DIR}/imgui/CMakeLists.txt ${CMAKE_BINARY_DIR}/${_target}/src/CMakeLists.txt && ${CMAKE_COMMAND} -E
copy_directory ${CMAKE_BINARY_DIR}/${_target}/deps/implot ${CMAKE_BINARY_DIR}/${_target}/src/implot && ${CMAKE_COMMAND} -E copy_directory
${CMAKE_BINARY_DIR}/${_target}/deps/imgui-backend-qt/backends ${CMAKE_BINARY_DIR}/${_target}/src/backends && ${CMAKE_COMMAND} -E copy_directory
${CMAKE_BINARY_DIR}/${_target}/deps/imgui-node-editor ${CMAKE_BINARY_DIR}/${_target}/src/imgui-node-editor && ${_patch_command_for_imgui_backend_qt} &&
${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_SOURCE_DIR}/imgui/CMakeLists.txt ${_base_dir}/src/CMakeLists.txt && ${CMAKE_COMMAND} -E copy_directory
${_base_dir}/deps/implot ${_base_dir}/src/implot && ${CMAKE_COMMAND} -E copy_directory ${_base_dir}/deps/imgui-backend-qt/backends ${_base_dir}/src/backends
&& ${CMAKE_COMMAND} -E copy_directory ${_base_dir}/deps/imgui-node-editor ${_base_dir}/src/imgui-node-editor && ${_patch_command_for_imgui_backend_qt} &&
${_patch_command_for_imgui}
CONFIGURE_COMMAND ${CMAKE_COMMAND} ${_configure_options} -DFIND_QT_VERSION=${_find_qt_version} -DCMAKE_PREFIX_PATH=${_qt_location}/lib/cmake
BUILD_COMMAND ${_cmake_build_command}
Expand Down