build: add PySide6 fallback mappings for clang 18 through 22 - #1383
Open
todd-ghub wants to merge 1 commit into
Open
build: add PySide6 fallback mappings for clang 18 through 22#1383todd-ghub wants to merge 1 commit into
todd-ghub wants to merge 1 commit into
Conversation
get_fallback_clang_filename_suffix() stops at clang 17, so a newer toolchain falls through with None and no matching universal PySide6 build is resolved. Xcode 16 ships clang 18 and Xcode 26 ships clang 21, so this affects any current macOS toolchain. Adds the 18.0 through 22.0 entries following the existing pattern. Purely additive - no existing mapping is changed, so behaviour on clang 17 and older is unaffected. Signed-off-by: Todd Shifflett <todd@combustiblelabs.com>
todd-ghub
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
August 18, 2026 21:14
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
None — small additive build fix.
Summarize your change.
Adds PySide6 fallback filename mappings for clang major versions 18 through 22 in
get_fallback_clang_filename_suffix().Adds the 18.0 through 22.0 entries following the existing pattern. Purely additive - no existing mapping is changed, so behavior on clang 17 and older is unaffected.
Describe the reason for the change.
get_fallback_clang_filename_suffix() stops at clang 17, so a newer toolchain falls through with None and no matching universal PySide6 build is resolved. Xcode 16 ships clang 18 and Xcode 26 ships clang 21, so this affects any current macOS toolchain.
The dispatch stopped at clang 17 and returned
Nonefor anything newer, so no fallback PySide6 universal build was resolved on any current macOS toolchain. Xcode 16 ships Apple clang 18; Xcode 26 ships Apple clang 21.Describe what you have tested and on which operating system.
Built on macOS 26.5.1 (arm64) with Apple clang 21.0.0 (clang-2100.1.1.101),
Xcode 26.6. The clang 21 path is the one exercised directly.
The 18.0, 19.0, 20.0 and 22.0 entries follow the same naming scheme as the existing entries but have not been built against those toolchains — happy to narrow this to just 21.0 if you would rather only land what is verified.
Not tested on Linux or Windows. The change is inside the macOS branch of the function, so other platforms are unaffected.
Add a list of changes, and note any that might need special attention during the review.
src/build/make_pyside6.py: fiveelifbranches added toget_fallback_clang_filename_suffix(). 10 insertions, 0 deletions.Worth a reviewer's attention: the PySide6 build strings for 18–22 follow the established convention, but please confirm those artifacts exist for each version.
If possible, provide screenshots.