-
Notifications
You must be signed in to change notification settings - Fork 196
Update Rocky Linux 8.7 Build Instructions and Replace .tsh with .sh #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rocky Linux 8.7 Build Instructions and Replace .tsh with .sh #384
Conversation
|
geffrak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great! Thanks for your contribution. I somehow missed it.
| @@ -1,97 +1,64 @@ | |||
| #!/bin/tcsh -f | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do the other wrappers too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for other wrappers? Is there any system that doesn't use sh out of the box?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean rvio.wrapper, py-interp.wrapper, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geffrak I think I found all the tcsh scripts. Lmk what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geffrak thoughts?
785a177 to
5420b99
Compare
|
Hello @beatreichenbach, We would very much like to get this excellent work of yours for the .tcsh with .sh replacement. Thank you so much for your contribution ! |
23bde9e to
5d3b077
Compare
bernie-laberge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Fantastic @beatreichenbach !
Thank you so much for your contribution and I apologize for the huge delay.
Sure, I can remove them, however I think it might be worth taking a look at how concise my update was vs what was there before. The previous docs also didn't help me build OpenRV in a docker container (meaning it was reproducible!) as I had to fix a bunch of stuff that wasn't in there. |
|
This is getting really outdated... What's the status here? |
5d3b077 to
fd96279
Compare
|
Hi @beatreichenbach the team was really focused on other issues but over the next while I'll try to clear up some of the older PRs here, including yours :) Due to the length of time it has taken, and because we require DCO/EasyCLA, I may end up re-doing your PR myself, but the goal is to include your updates. |
revert changes Signed-off-by: pbergeron-adsk <[email protected]>
Revert changes Signed-off-by: pbergeron-adsk <[email protected]>
removed last line diff Signed-off-by: pbergeron-adsk <[email protected]>
|
Hi @pbergeron-adsk, thank you for taking this on. |
|
Hi @beatreichenbach, there are conflicts in all the wrapper because the Qt6 feature branch was merged into main. The conflicts are about using the right OpenSSL based on the VFX platform. Are you able to fix those conflicts? Otherwise, I can fork your branch and work on the changes myself. Thank you! |
@cedrik-fuoco-adsk Unfortunately I'm unable to do this in the next couple weeks. If you have the bandwidth, please go ahead and take this over. Otherwise I will revisit this sometime in the future. Thanks! |
|
This PR has been taken over by #789. Thank you @beatreichenbach ! |
Linked issues
Related discussions
#346
#352
#90
#382
Summarize your change.
Adding documentation for Rocky Linux 8.7 Build.
Describe the reason for the change.
The existing documentation was lacking.
Describe what you have tested and on which operating system.
Rocky Linux 8.7
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.