Add RV as a participant using the new Live Review schema #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloisebrosseau
requested review from
bernie-laberge and
cedrik-fuoco-adsk
as code owners
eloisebrosseau
changed the title
eloisebrosseau
force-pushed
the
live-review
branch
2 times, most recently
from
69eda0b to
cc45e67
Compare
eloisebrosseau
force-pushed
the
live-review
branch
from
cc45e67 to
e5d92be
Compare
Signed-off-by: Éloïse Brosseau <[email protected]>
Signed-off-by: Éloïse Brosseau <[email protected]>
Signed-off-by: Éloïse Brosseau <[email protected]>
eloisebrosseau
force-pushed
the
live-review
branch
from
e5d92be to
428d9e5
Compare
bernie-laberge
approved these changes
Oct 23, 2024
Contributor
bernie-laberge
left a comment
bernie-laberge
left a comment
There was a problem hiding this comment.
LGTM
Thank you Éloïse!
eloisebrosseau
merged commit e055db3
into
AcademySoftwareFoundation:main
12 checks passed
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 7, 2024
…wareFoundation#602) ### Add RV as a participant using the new Live Review schema ### Summarize your change. The `read_otio_string` function was added to parse the OTIO object containing the timeline sent by the Review App when RV is joining a new session as a participant. Since the timeline contains some annotation fields, the annotation schema was added in order to let OTIO know that it is a known schema during the deserialization step. However, nothing is done with the annotations at this stage. ### Describe the reason for the change. This is the first step in adding back the new OTIO schema as the preferred way of communication between RV and the Review App. ### Describe what you have tested and on which operating system. Live review using the new schema was tested between a local Review App where the feature was enabled with https://creative-collab.dev.shotguncloud.com and RV on MacOS. --------- Signed-off-by: Éloïse Brosseau <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 8, 2024
…wareFoundation#602) ### Add RV as a participant using the new Live Review schema ### Summarize your change. The `read_otio_string` function was added to parse the OTIO object containing the timeline sent by the Review App when RV is joining a new session as a participant. Since the timeline contains some annotation fields, the annotation schema was added in order to let OTIO know that it is a known schema during the deserialization step. However, nothing is done with the annotations at this stage. ### Describe the reason for the change. This is the first step in adding back the new OTIO schema as the preferred way of communication between RV and the Review App. ### Describe what you have tested and on which operating system. Live review using the new schema was tested between a local Review App where the feature was enabled with https://creative-collab.dev.shotguncloud.com and RV on MacOS. --------- Signed-off-by: Éloïse Brosseau <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 28, 2024
…wareFoundation#602) ### Add RV as a participant using the new Live Review schema ### Summarize your change. The `read_otio_string` function was added to parse the OTIO object containing the timeline sent by the Review App when RV is joining a new session as a participant. Since the timeline contains some annotation fields, the annotation schema was added in order to let OTIO know that it is a known schema during the deserialization step. However, nothing is done with the annotations at this stage. ### Describe the reason for the change. This is the first step in adding back the new OTIO schema as the preferred way of communication between RV and the Review App. ### Describe what you have tested and on which operating system. Live review using the new schema was tested between a local Review App where the feature was enabled with https://creative-collab.dev.shotguncloud.com and RV on MacOS. --------- Signed-off-by: Éloïse Brosseau <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 25, 2025
…wareFoundation#602) ### Add RV as a participant using the new Live Review schema ### Summarize your change. The `read_otio_string` function was added to parse the OTIO object containing the timeline sent by the Review App when RV is joining a new session as a participant. Since the timeline contains some annotation fields, the annotation schema was added in order to let OTIO know that it is a known schema during the deserialization step. However, nothing is done with the annotations at this stage. ### Describe the reason for the change. This is the first step in adding back the new OTIO schema as the preferred way of communication between RV and the Review App. ### Describe what you have tested and on which operating system. Live review using the new schema was tested between a local Review App where the feature was enabled with https://creative-collab.dev.shotguncloud.com and RV on MacOS. --------- Signed-off-by: Éloïse Brosseau <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 28, 2025
…wareFoundation#602) ### Add RV as a participant using the new Live Review schema ### Summarize your change. The `read_otio_string` function was added to parse the OTIO object containing the timeline sent by the Review App when RV is joining a new session as a participant. Since the timeline contains some annotation fields, the annotation schema was added in order to let OTIO know that it is a known schema during the deserialization step. However, nothing is done with the annotations at this stage. ### Describe the reason for the change. This is the first step in adding back the new OTIO schema as the preferred way of communication between RV and the Review App. ### Describe what you have tested and on which operating system. Live review using the new schema was tested between a local Review App where the feature was enabled with https://creative-collab.dev.shotguncloud.com and RV on MacOS. --------- Signed-off-by: Éloïse Brosseau <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 28, 2025
…wareFoundation#602) ### Add RV as a participant using the new Live Review schema ### Summarize your change. The `read_otio_string` function was added to parse the OTIO object containing the timeline sent by the Review App when RV is joining a new session as a participant. Since the timeline contains some annotation fields, the annotation schema was added in order to let OTIO know that it is a known schema during the deserialization step. However, nothing is done with the annotations at this stage. ### Describe the reason for the change. This is the first step in adding back the new OTIO schema as the preferred way of communication between RV and the Review App. ### Describe what you have tested and on which operating system. Live review using the new schema was tested between a local Review App where the feature was enabled with https://creative-collab.dev.shotguncloud.com and RV on MacOS. --------- Signed-off-by: Éloïse Brosseau <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RV as a participant using the new Live Review schema
Summarize your change.
The
read_otio_stringfunction was added to parse the OTIO object containing the timeline sent by the Review App when RV is joining a new session as a participant. Since the timeline contains some annotation fields, the annotation schema was added in order to let OTIO know that it is a known schema during the deserialization step. However, nothing is done with the annotations at this stage.Describe the reason for the change.
This is the first step in adding back the new OTIO schema as the preferred way of communication between RV and the Review App.
Describe what you have tested and on which operating system.
Live review using the new schema was tested between a local Review App where the feature was enabled with https://creative-collab.dev.shotguncloud.com and RV on MacOS.