Fix build break on CentOS #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Éloïse Brosseau <[email protected]>
eloisebrosseau
requested review from
bernie-laberge and
cedrik-fuoco-adsk
as code owners
cedrik-fuoco-adsk
approved these changes
Oct 16, 2024
bernie-laberge
merged commit dd73ec4
into
AcademySoftwareFoundation:main
11 checks passed
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 25, 2025
### Fix build break on CentOS ### Summarize your change. Set `pyzstd` and `py7zr` to the maximum version working with Python 3.8. ### Describe the reason for the change. The version of `pyzstd` required by the latest version of `py7zr` doesn't work with Python 3.8 which is used with CentOS 7 which is causing a build break. This fix should be removed once the support for CentOS is dropped. ### Describe what you have tested and on which operating system. The build step was tested on CentOS 7. Signed-off-by: Éloïse Brosseau <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 28, 2025
### Fix build break on CentOS ### Summarize your change. Set `pyzstd` and `py7zr` to the maximum version working with Python 3.8. ### Describe the reason for the change. The version of `pyzstd` required by the latest version of `py7zr` doesn't work with Python 3.8 which is used with CentOS 7 which is causing a build break. This fix should be removed once the support for CentOS is dropped. ### Describe what you have tested and on which operating system. The build step was tested on CentOS 7. Signed-off-by: Éloïse Brosseau <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 28, 2025
### Fix build break on CentOS ### Summarize your change. Set `pyzstd` and `py7zr` to the maximum version working with Python 3.8. ### Describe the reason for the change. The version of `pyzstd` required by the latest version of `py7zr` doesn't work with Python 3.8 which is used with CentOS 7 which is causing a build break. This fix should be removed once the support for CentOS is dropped. ### Describe what you have tested and on which operating system. The build step was tested on CentOS 7. Signed-off-by: Éloïse Brosseau <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build break on CentOS
Summarize your change.
Set
pyzstdandpy7zrto the maximum version working with Python 3.8.Describe the reason for the change.
The version of
pyzstdrequired by the latest version ofpy7zrdoesn't work with Python 3.8 which is used with CentOS 7 which is causing a build break. This fix should be removed once the support for CentOS is dropped.Describe what you have tested and on which operating system.
The build step was tested on CentOS 7.