Set default value for ffmpeg threads to 1 instead of the implicit 0. #671
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenmcgaugh
requested review from
bernie-laberge,
eloisebrosseau and
cedrik-fuoco-adsk
as code owners
…When set to 0 RV's thread count will explode since it will create (num_cpus+1)*(num_sources)*(num_reader_threads) threads. To restore previous behaviour set env var RV_MOVIEFFMPEG_ARGS="-codecThreads 0". Signed-off-by: Ken McGaugh <[email protected]>
kenmcgaugh
force-pushed
the
ffmpeg-threads
branch
from
8598d78 to
d77d51b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set to 0 RV's thread count will explode since it will create (num_cpus+1)(num_sources)(num_reader_threads) threads. In my test of loading 25 prores clips RV's thread count grew to 726 and consumed 10GB of memory. With this change in place, the thread count remained stable at 49 and memory used was 7.5GB.
To restore previous behaviour you can set the env var RV_MOVIEFFMPEG_ARGS="--codecThreads 0".