Fix rv.commands.clearSession() caching issue #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernard Laberge <[email protected]>
bernie-laberge
requested review from
eloisebrosseau and
cedrik-fuoco-adsk
as code owners
eloisebrosseau
approved these changes
Feb 21, 2025
rogernelson
approved these changes
Feb 25, 2025
bernie-laberge
merged commit 95e1f53
into
AcademySoftwareFoundation:main
10 checks passed
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Mar 3, 2025
…on#698) ### Fix rv.commands.clearSession() caching issue ### Linked issues NA ### Describe the reason for the change. **Problem:** In some situations, invoking the rv.commands.clearSession() would leave with the caching turned off for the remainder of the RV process lifetime which was impacting playback performances for the remainder of the RV process lifetime. Note that the caching=off would not be persisted. So at the next RV relaunch, the caching would be enabled. This problem can be reproduced when importing an OTIO into RV. Before the OTIO import, caching is on: <img width="490" alt="rv_cache_is_initially_on_good" src="https://github.com/user-attachments/assets/83e0089f-9cb0-4662-98e0-377f81809be0" /> After the OTIO import, the media caching would be effectively disabled: <img width="490" alt="rv_cache_is_turned_off_after_otio_import" src="https://github.com/user-attachments/assets/f6f348bf-b003-4854-9726-441b4bbb62e7" /> ### Summarize your change. **Cause:** This was caused by the rv.commands.clearSession() which momentarily turn off caching to empty its content. But the original caching state is never restored until the user relaunches RV. **Fix:** Now restoring the original caching state in Session::clear(). ### Describe what you have tested and on which operating system. Successfully tested on macOS. This issue is not OS specific. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Bernard Laberge <[email protected]>
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Mar 3, 2025
…on#698) ### Fix rv.commands.clearSession() caching issue ### Linked issues NA ### Describe the reason for the change. **Problem:** In some situations, invoking the rv.commands.clearSession() would leave with the caching turned off for the remainder of the RV process lifetime which was impacting playback performances for the remainder of the RV process lifetime. Note that the caching=off would not be persisted. So at the next RV relaunch, the caching would be enabled. This problem can be reproduced when importing an OTIO into RV. Before the OTIO import, caching is on: <img width="490" alt="rv_cache_is_initially_on_good" src="https://github.com/user-attachments/assets/83e0089f-9cb0-4662-98e0-377f81809be0" /> After the OTIO import, the media caching would be effectively disabled: <img width="490" alt="rv_cache_is_turned_off_after_otio_import" src="https://github.com/user-attachments/assets/f6f348bf-b003-4854-9726-441b4bbb62e7" /> ### Summarize your change. **Cause:** This was caused by the rv.commands.clearSession() which momentarily turn off caching to empty its content. But the original caching state is never restored until the user relaunches RV. **Fix:** Now restoring the original caching state in Session::clear(). ### Describe what you have tested and on which operating system. Successfully tested on macOS. This issue is not OS specific. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Bernard Laberge <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
richardssam
pushed a commit
to richardssam/OpenRV
that referenced
this pull request
Jun 17, 2025
…on#698) ### Fix rv.commands.clearSession() caching issue ### Linked issues NA ### Describe the reason for the change. **Problem:** In some situations, invoking the rv.commands.clearSession() would leave with the caching turned off for the remainder of the RV process lifetime which was impacting playback performances for the remainder of the RV process lifetime. Note that the caching=off would not be persisted. So at the next RV relaunch, the caching would be enabled. This problem can be reproduced when importing an OTIO into RV. Before the OTIO import, caching is on: <img width="490" alt="rv_cache_is_initially_on_good" src="https://github.com/user-attachments/assets/83e0089f-9cb0-4662-98e0-377f81809be0" /> After the OTIO import, the media caching would be effectively disabled: <img width="490" alt="rv_cache_is_turned_off_after_otio_import" src="https://github.com/user-attachments/assets/f6f348bf-b003-4854-9726-441b4bbb62e7" /> ### Summarize your change. **Cause:** This was caused by the rv.commands.clearSession() which momentarily turn off caching to empty its content. But the original caching state is never restored until the user relaunches RV. **Fix:** Now restoring the original caching state in Session::clear(). ### Describe what you have tested and on which operating system. Successfully tested on macOS. This issue is not OS specific. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Bernard Laberge <[email protected]> Signed-off-by: [email protected] <[email protected]>
richardssam
pushed a commit
to richardssam/OpenRV
that referenced
this pull request
Jun 17, 2025
…on#698) ### Fix rv.commands.clearSession() caching issue ### Linked issues NA ### Describe the reason for the change. **Problem:** In some situations, invoking the rv.commands.clearSession() would leave with the caching turned off for the remainder of the RV process lifetime which was impacting playback performances for the remainder of the RV process lifetime. Note that the caching=off would not be persisted. So at the next RV relaunch, the caching would be enabled. This problem can be reproduced when importing an OTIO into RV. Before the OTIO import, caching is on: <img width="490" alt="rv_cache_is_initially_on_good" src="https://github.com/user-attachments/assets/83e0089f-9cb0-4662-98e0-377f81809be0" /> After the OTIO import, the media caching would be effectively disabled: <img width="490" alt="rv_cache_is_turned_off_after_otio_import" src="https://github.com/user-attachments/assets/f6f348bf-b003-4854-9726-441b4bbb62e7" /> ### Summarize your change. **Cause:** This was caused by the rv.commands.clearSession() which momentarily turn off caching to empty its content. But the original caching state is never restored until the user relaunches RV. **Fix:** Now restoring the original caching state in Session::clear(). ### Describe what you have tested and on which operating system. Successfully tested on macOS. This issue is not OS specific. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Bernard Laberge <[email protected]> Signed-off-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rv.commands.clearSession() caching issue
Linked issues
NA
Describe the reason for the change.
Problem:
In some situations, invoking the rv.commands.clearSession() would leave with the caching turned off for the remainder of the RV process lifetime which was impacting playback performances for the remainder of the RV process lifetime.
Note that the caching=off would not be persisted. So at the next RV relaunch, the caching would be enabled.
This problem can be reproduced when importing an OTIO into RV.
Before the OTIO import, caching is on:
After the OTIO import, the media caching would be effectively disabled:
Summarize your change.
Cause:
This was caused by the rv.commands.clearSession() which momentarily turn off caching to empty its content.
But the original caching state is never restored until the user relaunches RV.
Fix:
Now restoring the original caching state in Session::clear().
Describe what you have tested and on which operating system.
Successfully tested on macOS. This issue is not OS specific.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.