Feature/Qt6 - Export dialog will freeze at the end of an export #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s returned by rvio while starting its job Signed-off-by: Patrick Bergeron <[email protected]>
pbergeron-adsk
requested review from
bernie-laberge,
eloisebrosseau and
cedrik-fuoco-adsk
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
When exporting (or, for that matter, calling an external process) was finished, the "finish" callback faied and caused RV to crash.
The fix was simply to add a missing parameter at the end of the signature of the callback method called by connect() when QProcess.finish is called, to match what is expected in Qt6.
Describe the reason for the change.
Fixes crash at end of export process
Describe what you have tested and on which operating system.
Tested on Linux64 Rocky 9.5.
NOTE: This change in signature may not be compatible with building RV with Qt5
Add a list of changes, and note any that might need special attention during the review.
n/a
If possible, provide screenshots.
n/a