Skip to content

717: Fix OUTPUT path of windows openssl cmake custom command #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

herronelou
Copy link

Linked issues

#717

Summarize your change.

The custom command's OUTPUT was pointing at the RV_STAGE_LIB_DIR, however the copy commands below were copying the files to the RV_STAGE_BIN_DIR (LIB vs BIN), always resulting in a warning during build:

       "C:\OpenRV\_build\cmake\dependencies\dependencies.vcxproj" (default target) (1) ->
       "C:\OpenRV\_build\cmake\dependencies\RV_DEPS_OPENSSL-stage-target.vcxproj" (default target)
       (15) ->
       (CustomBuild target) ->
         C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsof
       t.CppCommon.targets(237,5): warning MSB8065: Custom build for item "C:\OpenRV\_build\CMakeFi
       les\d2708addcadbb8629f109d12d3d452c4\libcrypto-1_1-x64.dll.rule" succeeded, but specified ou
       tput "c:\openrv\_build\stage\app\lib\libcrypto-1_1-x64.dll" has not been created. This may c
       ause incremental build to work incorrectly. [C:\OpenRV\_build\cmake\dependencies\RV_DEPS_OPE
       NSSL-stage-target.vcxproj]
         C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsof
       t.CppCommon.targets(237,5): warning MSB8065: Custom build for item "C:\OpenRV\_build\CMakeFi
       les\d2708addcadbb8629f109d12d3d452c4\libcrypto-1_1-x64.dll.rule" succeeded, but specified ou
       tput "c:\openrv\_build\stage\app\lib\libssl-1_1-x64.dll" has not been created. This may caus
       e incremental build to work incorrectly. [C:\OpenRV\_build\cmake\dependencies\RV_DEPS_OPENSS
       L-stage-target.vcxproj]

Describe the reason for the change.

To not get this warning anymore.

Describe what you have tested and on which operating system.

On Windows, it doesn't show the warning anymore.

Add a list of changes, and note any that might need special attention during the review.

NA

If possible, provide screenshots.

NA

Copy link
Contributor

@bernie-laberge bernie-laberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ! Thanks!

@cedrik-fuoco-adsk
Copy link
Contributor

@herronelou Could you fix the issue with the DCO?

@wywarren
Copy link
Contributor

wywarren commented May 3, 2025

Ahh I was just about to PR this. Thanks for the submission. Hopefully this gets merged soon.

@herronelou herronelou force-pushed the 717_open_ssl_cmake branch from ed28bb8 to d32c9a6 Compare May 3, 2025 22:40
@herronelou
Copy link
Author

DCO fixed (and code rebased on main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants