SG-40370: Fix Y-Inverted Color Picker #849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes color inspector not working on FileSources that have has multiple video sources with different orientations Signed-off-by: Mark Reid <[email protected]>
markreidvfx
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
pbergeron-adsk
approved these changes
Sep 2, 2025
eloisebrosseau
approved these changes
Sep 15, 2025
bernie-laberge
changed the title
Contributor
|
Testing successfully completed. Ready to merge. |
Signed-off-by: Bernard Laberge <[email protected]>
bernie-laberge
merged commit 9c15157
into
AcademySoftwareFoundation:main
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Fixes the color inspector from calculating the wrong coordinate when a RVFileSources has multiple media paths with different orientations
We use multiple media paths to add audio to images sequences from a proxy mov file.
The current logic is to use the
ImageStructureInfoof last movie in the list and not what is currently visible. In some cases the second path might have a different coordinate system then the image sequence. In our cases the Y coordinate is opposite causing the color picker sample location to be upside down.This change reuses the exisiting
getMediaFromContextmethod to get the same media that is displayed.Describe what you have tested and on which operating system.
Linux, macOS