SG-41316: Add Dissolve blend composite mode to stackIPNode with UI controls #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a new dissolve blend composite mode for OpenRV's stack compositor with full UI integration and real-time controls. Features: - Dissolve blend mode in StackIPNode for 2-input compositing - GPU shader implementation (Dissolve2.glsl) with configurable dissolve amount - UI slider and text input controls in Session Manager - Real-time dissolve amount adjustment (0.0 to 1.0 range) - Immediate UI updates when switching between composite modes Technical Implementation: - StackIPNode.cpp: Added dissolve mode support with m_dissolveAmount property - ShaderCommon.cpp: Implemented newDissolveBlend() function for GPU shader management - Dissolve2.glsl: GLSL shader for hardware-accelerated dissolve blending - composite.ui: Added QSlider and QLineEdit controls for dissolve amount - Composite_edit_mode.mu: Enhanced with slider integration and UI synchronization - CMakeLists.txt: Updated build configuration for dissolve shader compilation Tested on macOS with existing OpenRV build system. UI controls properly show/hide when switching composite modes, and dissolve blending works correctly with 2-input stacks. Signed-off-by: nigel sumner <[email protected]>
nigelsumner
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
pbergeron-adsk
approved these changes
Oct 10, 2025
Contributor
pbergeron-adsk
left a comment
pbergeron-adsk
left a comment
There was a problem hiding this comment.
This looks OK to me, needs to be view tested.
| F = blend(size, name, | ||
| overShaders[size - 2]); //*2_glsl is at position 0 | ||
| break; | ||
| // TODO: dissolve |
Contributor
There was a problem hiding this comment.
Thank you @nigelsumner for adding the dissolve !
(I checked in the git history of the original RV code base and this comment dates back from 13 years ago)
|
|
||
| IntProperty* autoSizeProperty() const { return m_autoSize; } | ||
|
|
||
| // float dissolveAmount() const { return m_dissolveAmount->front(); } |
Contributor
There was a problem hiding this comment.
Detail: Please remove if not used: we prefer not to leave any deadcode if possible unless you think it might be useful.
| maya_tools.mu | ||
| # See rvnuke_mode.mu.in | ||
| rvnuke_mode.mu | ||
| rvnuke_mode.musrc/plugins/rv-packages/session_manager/composite_ui.py |
Contributor
There was a problem hiding this comment.
I believe there is a newline missing after rvnuke_mode.mu and before composite_ui.py.
Also: where are those *_ui.py files coming from ?
bernie-laberge
approved these changes
Dec 1, 2025
Contributor
bernie-laberge
left a comment
bernie-laberge
left a comment
There was a problem hiding this comment.
Thank you @nigelsumner for this great contribution !
bernie-laberge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dissolve blend composite mode with UI controls
This PR implements a new dissolve blend composite mode for OpenRV's stack compositor with full UI integration and real-time controls.
OpenRV_dissolveBlend.mov
Features Added
Dissolve2.glsl) with configurable amountTechnical Implementation
Core Implementation
StackIPNode.cpp: Added dissolve mode support withm_dissolveAmountpropertyStackIPNode.h: Added property declaration for dissolve amount controlShaderCommon.cpp/.h: ImplementednewDissolveBlend()function for GPU shader managementGPU Shaders
Dissolve2.glsl: GLSL shader for hardware-accelerated dissolve blendingUI Integration
composite.ui: AddedQSliderandQLineEditcontrols for dissolve amountComposite_edit_mode.mu: Enhanced with slider integration and UI synchronizationBuild System
CMakeLists.txt: Updated build configuration for dissolve shader compilationTesting
Usage