Skip to content

Fix 40934: RVDisplayGroup's transfer function not being set to sRGB when loading media via pyeval #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix 40934: RVDisplayGroup's transfer function not being set to sRGB when loading media via pyeval #997

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b9b455
Fix 40934: sRGB not being loaded properly.
pbergeron-adsk Nov 21, 2025
f3de924
Merge branch 'main' into fix_pyeval_displaygroup_not_being_set
pbergeron-adsk Nov 21, 2025
3aeadbe
Merge branch 'main' into fix_pyeval_displaygroup_not_being_set
pbergeron-adsk Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/plugins/rv-packages/source_setup/source_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,14 @@ def setDisplayFromProfile(self):
dICCNode = groupMemberOfType(dpipe, "ICCDisplayTransform")
if dICCNode:
commands.setIntProperty(dICCNode + ".node.active", [0], True)

if dgroup is not None and commands.nodeType(dgroup) == "RVDisplayGroup" and dgroup not in dnodesWithProfile:
# BUGFIX: Also handle RVOutputGroup in addition to RVDisplayGroup
# When RV is run in command-line mode (e.g., via -pyeval), it uses RVOutputGroup
# instead of RVDisplayGroup for the default display output
if (
Copy link
Contributor

@bernie-laberge bernie-laberge Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really like to know what changed which led to this regression. I'll do some research in the original RV git repo and report back.

dgroup is not None
and commands.nodeType(dgroup) in ["RVDisplayGroup", "RVOutputGroup"]
and dgroup not in dnodesWithProfile
):
dICC = commands.getStringProperty(dgroup + ".device.systemProfileURL")
if dICCNode and len(dICC) == 1 and not dICC[0] == "":
dICCPath = urlparse(dICC[0].replace("%20", " ")).path
Expand Down Expand Up @@ -504,6 +510,9 @@ def checkForDisplayGroup(self, event):
event.reject()
if commands.nodeType(event.contents()) == "RVDisplayGroup":
self._haveNewDisplayGroups = True
# BUGFIX: When a new RVDisplayGroup is created AFTER initial setup
# (e.g., when UI starts after -pyeval), configure it immediately
self.setDisplayFromProfile()
Copy link
Contributor

@bernie-laberge bernie-laberge Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this interfere with the ocio_source_setup.py if OCIO mode is enabled ?

Copy link
Contributor

@bernie-laberge bernie-laberge Nov 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be safer to move the pyeval further down the line where we know that the RVDisplayGroup has been properly initialized.
Like here for example:

OpenRV/src/lib/app/RvCommon/RvApplication.cpp

Line 879 in 65c6472


def __init__(self):
self._readingSession = False
Expand Down
Loading