Skip to content

SG-41182: Add id to Paint OTIO schema #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SG-41182: Add id to Paint OTIO schema #999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/plugins/rv-packages/otio_reader/paint_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
```python
Example:
myObject = otio.schemadef.Paint.Paint(
name, points, rgba, type, brush, layer_range, visible
name, id, points, rgba, type, brush, layer_range, visible
)
"""

Expand All @@ -35,15 +35,17 @@ class Paint(otio.core.SerializableObject):
def __init__(
self,
name: str = "",
points: list | None = None,
rgba: list | None = None,
id: str = "",
points: list = [],
rgba: list = [],
type: str = "",
brush: str = "",
layer_range: otio.opentime.TimeRange | None = None,
visible: bool = True,
) -> None:
super().__init__()
self.name = name
self.id = id
self.points = points
self.rgba = rgba
self.type = type
Expand All @@ -53,6 +55,8 @@ def __init__(

name = otio.core.serializable_field("name", required_type=str, doc=("name: expects a string"))

id = otio.core.serializable_field("id", required_type=str, doc=("name: expects a string"))

_points = otio.core.serializable_field(
"points", required_type=list, doc=("points: expects a list of point objects")
)
Expand Down Expand Up @@ -97,13 +101,13 @@ def layer_range(self, val):

def __str__(self) -> str:
return (
f"Paint({self.name}, {self.points}, {self.rgba}, {self.type}, "
f"Paint({self.name}, {self.id}, {self.points}, {self.rgba}, {self.type}, "
f"{self.brush}, {self.layer_range}, {self.visible})"
)

def __repr__(self) -> str:
return (
f"otio.schema.Paint(name={self.name!r}, points={self.points!r}, "
f"otio.schema.Paint(name={self.name!r}, id={self.id!r}, points={self.points!r}, "
f"rgba={self.rgba!r}, type={self.type!r}, brush={self.brush!r}, "
f"layer_range={self.layer_range!r}, visible={self.visible!r})"
)
Loading