Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH actions to fix CI builds #1828

Merged

Conversation

darbyjohnston
Copy link
Contributor

@darbyjohnston darbyjohnston commented Jan 30, 2025

Summarize your change.

This PR includes the changes from #1827 plus some additional changes to fix the CI:

  • Update dawidd6/action-download-artifact to v8
  • Update actions/setup-python to v5.4.0
  • Use ubuntu-24.04-arm for native Linux ARM builds (replacing the QEMU emulator builds)
  • Update pypa/cibuildwheel to v2.22.0

@github-actions github-actions bot added the ci label Jan 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (c0e97b0) to head (5cd833e).
Report is 35 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
+ Coverage   84.11%   84.75%   +0.63%     
==========================================
  Files         198      176      -22     
  Lines       22241    12711    -9530     
  Branches     4687     1181    -3506     
==========================================
- Hits        18709    10773    -7936     
+ Misses       2610     1760     -850     
+ Partials      922      178     -744     
Flag Coverage Δ
py-unittests 84.75% <ø> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 129 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2985df...5cd833e. Read the comment docs.

Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
@darbyjohnston darbyjohnston changed the title Troubleshooting upload-artifact action from v3 to v4 Update GH actions to fix CI builds Feb 3, 2025
@darbyjohnston darbyjohnston marked this pull request as ready for review February 3, 2025 22:53
Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darbyjohnston darbyjohnston merged commit e100920 into AcademySoftwareFoundation:main Feb 5, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants