Skip to content

Conversation

@ssteinbach
Copy link
Collaborator

@ssteinbach ssteinbach commented Mar 30, 2025

  • Fix traceback when using relative paths with one "/" and not two "/" were triggering a traceback - ie "./blah" but not "./blah/blah" in url_utils.
  • url_utils is used by the otioz adapter (Which is where this was originally reported)

Fixes #1817

@ssteinbach ssteinbach added this to the Public Beta 18 milestone Mar 30, 2025
@ssteinbach ssteinbach requested review from jminor and reinecke March 30, 2025 05:24
@ssteinbach ssteinbach force-pushed the relative_path_otioz branch from 75b8d5e to 98a532a Compare March 30, 2025 05:28
@ssteinbach ssteinbach added the Adapters Relating to the adapters that live in the separate repos label Mar 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (c0e97b0) to head (8bd1e99).
Report is 57 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1862      +/-   ##
==========================================
+ Coverage   84.11%   84.72%   +0.61%     
==========================================
  Files         198      177      -21     
  Lines       22241    12809    -9432     
  Branches     4687     1191    -3496     
==========================================
- Hits        18709    10853    -7856     
+ Misses       2610     1773     -837     
+ Partials      922      183     -739     
Flag Coverage Δ
py-unittests 84.72% <100.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/py-opentimelineio/opentimelineio/url_utils.py 85.18% <100.00%> (ø)
tests/test_url_conversions.py 95.45% <100.00%> (+0.10%) ⬆️

... and 129 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6fff83...8bd1e99. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ssteinbach ssteinbach added the bug A problem, flaw, or broken functionality. label Mar 30, 2025
Copy link
Contributor

@apetrynet apetrynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

* Relative paths with one "/" and not two "/" were triggering a
  traceback - ie "./blah" but not "./blah/blah".
@ssteinbach ssteinbach force-pushed the relative_path_otioz branch from 98a532a to 8bd1e99 Compare March 31, 2025 20:14
@meshula meshula merged commit be777fe into AcademySoftwareFoundation:main Apr 1, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Adapters Relating to the adapters that live in the separate repos bug A problem, flaw, or broken functionality. python-bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

otioconvert to OTIOZ fails with relative media target_urls

6 participants