Skip to content

Conversation

@jlskuz
Copy link
Contributor

@jlskuz jlskuz commented Apr 1, 2025

If the user explicitely requests to use find_package to use the system Imath it seems wrong to fallback to the delivered Imath

As discussed in #1859

If the user explicitely requests to use find_package to use the system Imath it seems wrong to fallback to the delivered Imath

Signed-off-by: Julius Künzel <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (c0e97b0) to head (f0bbf7a).
Report is 55 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1864      +/-   ##
==========================================
+ Coverage   84.11%   84.72%   +0.61%     
==========================================
  Files         198      177      -21     
  Lines       22241    12809    -9432     
  Branches     4687     1191    -3496     
==========================================
- Hits        18709    10853    -7856     
+ Misses       2610     1773     -837     
+ Partials      922      183     -739     
Flag Coverage Δ
py-unittests 84.72% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 131 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be777fe...f0bbf7a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@darbyjohnston
Copy link
Contributor

Looks good, thanks for following up on this.

@ssteinbach ssteinbach added this to the Public Beta 18 milestone Apr 2, 2025
@darbyjohnston darbyjohnston added the cmake issues with the cmake scripts label Apr 2, 2025
@darbyjohnston darbyjohnston merged commit edffd5d into AcademySoftwareFoundation:main Apr 2, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmake issues with the cmake scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants