Skip to content

Conversation

@darbyjohnston
Copy link
Contributor

@darbyjohnston darbyjohnston commented Sep 5, 2025

This PR removes the MinGW CI job. It seems to have intermittent failures and I don't think we have the resources to troubleshoot it each time:
https://github.com/darbyjohnston/OpenTimelineIO/actions/runs/17500902789/job/49713367017

Edit: Note that this doesn't remove the various fixes for MinGW, just the CI job.

Signed-off-by: Darby Johnston <[email protected]>
@github-actions github-actions bot added the ci label Sep 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.00%. Comparing base (c0e97b0) to head (619eaaf).
⚠️ Report is 66 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1935      +/-   ##
==========================================
+ Coverage   84.11%   85.00%   +0.88%     
==========================================
  Files         198      181      -17     
  Lines       22241    13074    -9167     
  Branches     4687     1206    -3481     
==========================================
- Hits        18709    11113    -7596     
+ Misses       2610     1778     -832     
+ Partials      922      183     -739     
Flag Coverage Δ
py-unittests 85.00% <ø> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 139 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3ca19d...619eaaf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Darby Johnston <[email protected]>
Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this. I agree with your assessment that we lack resources to maintain mingw builds at the moment. Can I suggest we comment it out for 30 days, and post an RFC in OTIO issues and ASWF Slack requesting a maintainer, and if none steps up, we delete it as you propose?

@darbyjohnston darbyjohnston changed the title Remove MinGW CI job Temporarily disable check_manifest on MinGW Sep 8, 2025
@darbyjohnston
Copy link
Contributor Author

I looked into it some more, and the part that is failing is the check_manifest step:
https://github.com/mgedmin/check-manifest

I skimmed their PRs and didn't see any related to the error we are seeing, so maybe for now we just disable that step. I updated the PR and added a todo comment to fix it at some point.

@darbyjohnston darbyjohnston merged commit f970d77 into AcademySoftwareFoundation:main Sep 8, 2025
47 checks passed
luzpaz pushed a commit to luzpaz/OpenTimelineIO that referenced this pull request Sep 10, 2025
…n#1935)

* Remove MinGW CI jobs

Signed-off-by: Darby Johnston <[email protected]>

* Comment out the MinGW job

Signed-off-by: Darby Johnston <[email protected]>

* Try just disabling the check-manifest and lint check

Signed-off-by: Darby Johnston <[email protected]>

* Add comment

Signed-off-by: Darby Johnston <[email protected]>

---------

Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: luzpaz <[email protected]>
@darbyjohnston darbyjohnston deleted the rm_mingw_ci branch November 1, 2025 15:21
@reinecke reinecke added this to the Public Beta 18 milestone Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants