Use doubles for colour management #1951
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the following effects: * VideoCrop * VideoScale * VideoRotate * VideoPosition * AudioVolume * AudioFade It also adds a canvas size parameter to the timeline, and updates the timeline schema version to 2 C++ tests for the new effects are also added
This commit: * Add python bindings for new effects * Updates timeline bindings for canvas size * Adds/fixes unit tests
When iterating down the timeline, respect source range durations, as well as start times.
I think these help the 'make <various core map stuff>' work
Add an effect to signal flipping of video about the horizontal or vertical axis
Rounded corner effect
Add flip effect
Memoization of range calculation
This reverts commit b0efcde.
Add new effects for color management
The unit tests began failing with cached time ranges, add a top level invalidator to make tests pass again
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of int64_t use doubles for all colour management parameters