Skip to content

Conversation

@darbyjohnston
Copy link
Contributor

This PR initializes Imath values created in Python to 0.0. In C++ the default constructor does not initialize the values which means they could be anything. This is done as an optimization for C++ but is probably not necessary and also unexpected in Python.

For example this was recently causing CI failures: #1955

Signed-off-by: Darby Johnston <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.11%. Comparing base (04ab39c) to head (045351f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1956   +/-   ##
=======================================
  Coverage   85.10%   85.11%           
=======================================
  Files         181      181           
  Lines       12768    12774    +6     
  Branches     1206     1206           
=======================================
+ Hits        10866    10872    +6     
  Misses       1719     1719           
  Partials      183      183           
Flag Coverage Δ
py-unittests 85.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ntimelineio/opentimelineio-bindings/otio_imath.cpp 92.59% <100.00%> (ø)
tests/test_box2d.py 96.07% <100.00%> (+0.24%) ⬆️
tests/test_v2d.py 97.56% <100.00%> (+0.09%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ab39c...045351f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@darbyjohnston darbyjohnston merged commit 30f6f56 into AcademySoftwareFoundation:main Nov 1, 2025
56 checks passed
@darbyjohnston darbyjohnston deleted the python_imath_init branch November 1, 2025 15:20
@reinecke reinecke added this to the Public Beta 18 milestone Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants