Skip to content

Conversation

@darbyjohnston
Copy link
Contributor

@darbyjohnston darbyjohnston commented Oct 27, 2025

This PR fixes a couple of issues with the C++ exports:

  • Add missing OPENTIMELINEIO_IMPORT_TYPE macro
  • Use the variable OTIO_SHARED_LIBS instead of BUILD_SHARED in src/opentime/CMakeLists.txt and src/opentimelineio/CMakeLists.txt
  • Add a comment that you need to define OPENTIME_STATIC and OTIO_STATIC when building as a static library. These are defined automatically if you use the OTIO CMake config: find_package(OpenTimelineIO)
  • Fix the typo: OPENTIMELINIO -> OPENTIMELINEIO

Signed-off-by: Darby Johnston <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.10%. Comparing base (c0e97b0) to head (c34086a).
⚠️ Report is 79 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1959      +/-   ##
==========================================
+ Coverage   84.11%   85.10%   +0.98%     
==========================================
  Files         198      181      -17     
  Lines       22241    12768    -9473     
  Branches     4687     1206    -3481     
==========================================
- Hits        18709    10866    -7843     
+ Misses       2610     1719     -891     
+ Partials      922      183     -739     
Flag Coverage Δ
py-unittests 85.10% <ø> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 131 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe0e05...c34086a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Darby Johnston <[email protected]>
@darbyjohnston darbyjohnston added bug A problem, flaw, or broken functionality. and removed time calculations opentime labels Oct 27, 2025
@darbyjohnston darbyjohnston added this to the Public Beta 18 milestone Oct 27, 2025
@darbyjohnston darbyjohnston requested a review from meshula October 27, 2025 18:14
@darbyjohnston darbyjohnston merged commit 60171a4 into AcademySoftwareFoundation:main Oct 27, 2025
56 checks passed
@darbyjohnston darbyjohnston deleted the cxx_exports_fix branch November 1, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A problem, flaw, or broken functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants