Skip to content

Conversation

@reinecke
Copy link
Collaborator

@reinecke reinecke commented Nov 6, 2025

Summarize your change.

Applies version specification and C++ linting for the 0.18.0 release.

Signed-off-by: Eric Reinecke <[email protected]>
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 82.75862% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.13%. Comparing base (4bfa445) to head (a72c66a).

Files with missing lines Patch % Lines
src/opentimelineio/color.h 57.14% 3 Missing ⚠️
src/opentimelineio/serialization.cpp 0.00% 3 Missing ⚠️
src/opentimelineio/clip.cpp 0.00% 2 Missing ⚠️
src/opentimelineio/effect.h 0.00% 1 Missing ⚠️
src/opentimelineio/item.h 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1969      +/-   ##
==========================================
+ Coverage   85.11%   85.13%   +0.02%     
==========================================
  Files         181      181              
  Lines       12774    12783       +9     
  Branches     1206     1206              
==========================================
+ Hits        10872    10883      +11     
+ Misses       1719     1717       -2     
  Partials      183      183              
Flag Coverage Δ
py-unittests 85.13% <82.75%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentime/rationalTime.cpp 84.76% <ø> (ø)
src/opentime/timeRange.h 98.38% <100.00%> (+0.02%) ⬆️
src/opentimelineio/color.cpp 96.73% <100.00%> (+0.48%) ⬆️
src/opentimelineio/composition.cpp 79.27% <100.00%> (ø)
src/opentimelineio/composition.h 82.75% <ø> (ø)
src/opentimelineio/deserialization.cpp 62.88% <100.00%> (-0.29%) ⬇️
src/opentimelineio/effect.cpp 100.00% <100.00%> (ø)
src/opentimelineio/stack.cpp 76.81% <100.00%> (ø)
src/opentimelineio/track.cpp 91.26% <100.00%> (+0.06%) ⬆️
src/opentimelineio/effect.h 80.00% <0.00%> (ø)
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfa445...a72c66a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@apetrynet apetrynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that familiar with c++ code formatting, so some of these changes don't make that much sense to me.
With exception to that, it looks good to me

@reinecke reinecke merged commit fe9f406 into AcademySoftwareFoundation:main Nov 6, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants