Skip to content

Conversation

@jlskuz
Copy link
Contributor

@jlskuz jlskuz commented Nov 13, 2025

This allows for find_package calls with a version requirement such as

find_package(OpenTimelineIO 0.18.0 REQUIRED)

without this patch it fails like

CMake Error at CMakeLists.txt:171 (find_package):
  Could not find a configuration file for package "OpenTimelineIO" that is
  compatible with requested version "0.18.0".
  The following configuration files were considered but not accepted:
    /usr/local/share/opentimelineio/OpenTimelineIOConfig.cmake, version: unknown

See also

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.13%. Comparing base (ad449d8) to head (34c41b0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1981   +/-   ##
=======================================
  Coverage   85.13%   85.13%           
=======================================
  Files         181      181           
  Lines       12783    12783           
  Branches     1206     1206           
=======================================
  Hits        10883    10883           
  Misses       1717     1717           
  Partials      183      183           
Flag Coverage Δ
py-unittests 85.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad449d8...34c41b0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This allows for find_package calls with a version requirement such as

find_package(OpenTimelineIO 0.18.0 REQUIRED)

See https://cmake.org/cmake/help/latest/command/find_package.html#search-modes and https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html#generating-a-package-version-file

Signed-off-by: Julius Künzel <[email protected]>
@jlskuz jlskuz force-pushed the work/cmake-versionconfig branch from 17117be to 34c41b0 Compare November 13, 2025 18:35
@darbyjohnston darbyjohnston added build issues building OTIO and removed time calculations opentime labels Nov 14, 2025
@darbyjohnston darbyjohnston added this to the 0.19.0 milestone Nov 14, 2025
@darbyjohnston darbyjohnston merged commit 2429dd5 into AcademySoftwareFoundation:main Nov 14, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build issues building OTIO

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants